From c7eceb7c26e589248e28900d35031cebda4c1b9f Mon Sep 17 00:00:00 2001 From: Frank Elsinga Date: Sun, 11 Jun 2023 23:54:56 +0200 Subject: [PATCH] Fix/remove review exception cast (#1564) * Replaced cast to ReviewException with a modal --------- Co-authored-by: ctsk <9384305+ctsk@users.noreply.github.com> --- .../in/tumcampusapp/component/ui/overview/MainFragment.kt | 5 ++--- app/src/main/res/values-de/strings.xml | 1 + app/src/main/res/values/strings.xml | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/de/tum/in/tumcampusapp/component/ui/overview/MainFragment.kt b/app/src/main/java/de/tum/in/tumcampusapp/component/ui/overview/MainFragment.kt index c404a01235..8ae62b98bf 100644 --- a/app/src/main/java/de/tum/in/tumcampusapp/component/ui/overview/MainFragment.kt +++ b/app/src/main/java/de/tum/in/tumcampusapp/component/ui/overview/MainFragment.kt @@ -15,9 +15,7 @@ import androidx.recyclerview.widget.RecyclerView import androidx.swiperefreshlayout.widget.SwipeRefreshLayout import androidx.work.WorkManager import com.google.android.material.snackbar.Snackbar -import com.google.android.play.core.review.ReviewException import com.google.android.play.core.review.ReviewManagerFactory -import com.google.android.play.core.review.model.ReviewErrorCode import com.zhuinden.fragmentviewbindingdelegatekt.viewBinding import de.tum.`in`.tumcampusapp.R import de.tum.`in`.tumcampusapp.component.other.generic.adapter.EqualSpacingItemDecoration @@ -187,7 +185,8 @@ class MainFragment : BaseFragment( } } else { // There was some problem, log or handle the error code. - @ReviewErrorCode val reviewErrorCode = (task.exception as ReviewException).errorCode + Utils.showToast(requireContext(), R.string.in_app_review_failed_to_start) + task.exception?.let { Utils.log(it) } } } } diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index cb01e3eae5..741091953d 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -818,4 +818,5 @@ Signatur: %5$s Startet jetzt Morgen %1$s In + In App ReviewFlow konnte nicht gestartet werden diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index b1c27aa4b0..4d4f81e842 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -873,4 +873,5 @@ Signature: %5$s Starts now Tomorrow %1$s In + In App ReviewFlow failed to start