Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checking for File support in evaporate breaks Safari when using web workers. #442

Open
fahadm opened this issue Oct 23, 2019 · 1 comment
Open

Checking for File support in evaporate breaks Safari when using web workers. #442

fahadm opened this issue Oct 23, 2019 · 1 comment

Comments

@fahadm
Copy link

fahadm commented Oct 23, 2019

Browser : Safari 12.0.3 inside Web Workers
Issue:

  • When using evaporate inside a web worker, on line 391 inside evaporate we check for the File support.
  • There is no direct file support inside Safari Web workers right now.
  • This prevents evaporate from working on Safari web workers even if the list of files are passed from the main thread.

Recommended solution:

  • Remove this particular check or change the check such that it is only run when not running inside a web worker.
@jakubzitny
Copy link
Collaborator

Agreed, PR welcome :)

Quick solution for you for now can be to define some kind of File in your webworker globally so Evaporate passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fahadm @jakubzitny