Admin Register and Admin Login links do not show up.

[kaladay]

1. What is the type of this issue?

   • User

     • Functional: the expected or intended functionality is not provided.
       Anonymous users need to be able to register and login as admins if allowed such access.

   • Developer
     A developer needs to locally regiter and login for any tasks restricted to certain access.

   • Operational
     Administrators need to be able to register and login.

The cause of why this is now suddenly a problem is unknown.

The existing logic here:

• scholars-angular/src/app/footer/footer.component.html

  Line 8 in 17ef08c

  <li class="list-inline-item" *ngIf="(isAuthenticated | async) === false">

  
  Has logic like:

 *ngIf="(isAuthenticated | async) === false"

The explicit requirement for false is fine boolean logic, but it turns out that it is not actually fine in practice.
The isAuthenticated is now some non-boolean literal value and is instead likely undefined or null.

Inverting the logic to *ngIf="(isAuthenticated | async) !== true" appears to solve the problem.

[wwtamu]

Are we sure this is not a development environment issue? This is not reproducible on labs, demos, or production.

Auth state authenticated is set false by default, https://github.com/TAMULib/scholars-angular/blob/tamu-main/src/app/core/store/auth/auth.reducer.ts#L28.

It is changed only by means of dispatching actions in which only one of them determines the authenticated value from logic.

https://github.com/TAMULib/scholars-angular/blob/tamu-main/src/app/core/store/auth/auth.effects.ts#L205
https://github.com/TAMULib/scholars-angular/blob/tamu-main/src/app/core/service/rest.service.ts#L23

Is it possible your work machine browser is configured overly secure and blocking JavaScript and/or it reading cookies?

[Dbreck-TAMU]

This issue exists on prod and each Scholars environment.

For further explanation, if a user has never logged into Scholars they cannot see the registration or login link. Please see the attached screenshot.