Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove CLI login flow #558

Closed
wants to merge 3 commits into from
Closed

refactor: remove CLI login flow #558

wants to merge 3 commits into from

Conversation

m-alisafaee
Copy link
Contributor

@m-alisafaee m-alisafaee commented Feb 28, 2022 •
edited by olevski
Loading

Fixes: #557

/deploy renku=ableuler-patch-1

@m-alisafaee
Copy link
Contributor Author

Related PRs:
SwissDataScienceCenter/renku#2491
SwissDataScienceCenter/renku-python#2722

@m-alisafaee m-alisafaee marked this pull request as ready for review March 1, 2022 09:54
@m-alisafaee m-alisafaee requested a review from a team as a code owner March 1, 2022 09:54
@m-alisafaee m-alisafaee mentioned this pull request Mar 1, 2022
Merged
@ableuler
Copy link
Contributor

ableuler commented Mar 3, 2022

Thanks @mohammad-sdsc. As mentioned, I suggest that we park this PR for a bit and have at least one Renku release which supports both CLI login options.

@m-alisafaee m-alisafaee mentioned this pull request Mar 16, 2022
Open
@ableuler ableuler force-pushed the 557-remove-cli-login-flow branch from 1c3058a to 95b3667 Compare April 1, 2022 08:22
@olevski olevski temporarily deployed to renku-ci-gw-558 April 22, 2022 08:34 Inactive
olevski
olevski approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the acceptance tests pass this LGTM.

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-gw-558.dev.renku.ch

@olevski olevski deployed to renku-ci-gw-558 April 22, 2022 12:41 Active
@rokroskar
Copy link
Member

part of #566

@rokroskar rokroskar closed this Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove custom auth flow for CLI login
5 participants
@m-alisafaee @ableuler @RenkuBot @rokroskar @olevski