Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebooks: convert http calls to direct calls #396

Open
Tracked by #303
sgaist opened this issue Sep 11, 2024 · 0 comments
Open
Tracked by #303

notebooks: convert http calls to direct calls #396

sgaist opened this issue Sep 11, 2024 · 0 comments

Comments

@sgaist
Copy link
Collaborator

sgaist commented Sep 11, 2024

Currently data_service.py contains the original code that would call the services implemented in renku-data-services. As a first step integration, calls are being made to localhost, the next step to remove that layer and tap directly into the backend.

@sgaist sgaist changed the title components/renku_data_services/notebooks/api/classes/data_service.py: I guess you'll do that in a followup PR but all the http calls in this file are superfluous and can be replaced with direct calls notebooks: convert http calls to direct calls Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant