Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate and then save auditlogs to S3 #635

Open
Tracked by #597
sgaist opened this issue Jul 15, 2024 · 3 comments
Open
Tracked by #597

Generate and then save auditlogs to S3 #635

sgaist opened this issue Jul 15, 2024 · 3 comments

Comments

@sgaist
Copy link
Collaborator

sgaist commented Jul 15, 2024

The implementation of Amalthea V1 provides an option to export logs from the operator to an S3 bucket.

This ticket tracks the port / re-implementation of this feature.

@sgaist
Copy link
Collaborator Author

sgaist commented Jul 15, 2024

@olevski @rokroskar

I was taking a look at the original implementation and the following question came to my mind: should that really be the responsibility of Amalthea to export it's own logs ?

Checking the k8s logging documentation, I was wondering if this should not be handled by a dedicated sidecar such as fluentd which provides a dedicated output for s3

@olevski
Copy link
Member

olevski commented Aug 8, 2024

@sgaist it would be nice if we can pull this off. The problem is that the audit logs are not just a subset of the plain application logs of the operator. But this should be a problem we can solve. I have never heard of fluentd but it seems like what we need.

@rokroskar
Copy link
Member

@sgaist I like your suggestion - I guess the first task would be to improve the logging in general. At the moment the logs are extremely generic and offer no view into how/when the sessions are being created/hibernated/removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants