diff --git a/apps/lib/data_provider/configs/resources/source_config_schemas/skeleton.json b/apps/lib/data_provider/configs/resources/source_config_schemas/skeleton.json index e3578258..6b76f1b0 100644 --- a/apps/lib/data_provider/configs/resources/source_config_schemas/skeleton.json +++ b/apps/lib/data_provider/configs/resources/source_config_schemas/skeleton.json @@ -6,8 +6,7 @@ "type": "string", "const": "skeleton" } - // TODO: add all other possible fields from your config object }, - "required": ["dataSource"], // TODO: add all other required fields here + "required": ["dataSource"], "additionalProperties": false } \ No newline at end of file diff --git a/apps/lib/data_provider/configs/source_config_tests/skeleton_test.go b/apps/lib/data_provider/configs/source_config_tests/skeleton_test.go index bda436d9..9cb54937 100644 --- a/apps/lib/data_provider/configs/source_config_tests/skeleton_test.go +++ b/apps/lib/data_provider/configs/source_config_tests/skeleton_test.go @@ -27,7 +27,8 @@ func TestValidSkeletonConfig(t *testing.T) { sourceSpecificConfig, err := skeleton.GetSourceSpecificConfig(sourceConfig) assert.NoError(t, err) + assert.NotNil(t, sourceSpecificConfig) // TODO: write some asserts to check that the fields on sourceSpecificConfig have the values you'd expect - panic("implement me") + t.Fatalf("implement me") } diff --git a/apps/lib/data_provider/sources/skeleton/data_source.go b/apps/lib/data_provider/sources/skeleton/data_source.go index 4f0b7b91..1fd12861 100644 --- a/apps/lib/data_provider/sources/skeleton/data_source.go +++ b/apps/lib/data_provider/sources/skeleton/data_source.go @@ -5,6 +5,7 @@ import ( ) type skeletonDataSource struct { + SkeletonConfig SkeletonConfig // TODO: set any necessary parameters } @@ -15,10 +16,12 @@ func newSkeletonDataSource(sourceConfig types.DataProviderSourceConfig) *skeleto } // TODO: add any necessary initialization code - panic("implement me") + return &skeletonDataSource{ + SkeletonConfig: skeletonConfig, + } } func (r skeletonDataSource) RunDataSource(updatesCh chan types.DataSourceUpdateMap) { - // TODO: Write all logic to fetch datapoints and add to updatesCh + // TODO: Write all logic to fetch data points and report them to updatesCh panic("implement me") } diff --git a/apps/lib/data_provider/sources/skeleton/data_source_test.go b/apps/lib/data_provider/sources/skeleton/data_source_test.go index 388919cc..d5a5964e 100644 --- a/apps/lib/data_provider/sources/skeleton/data_source_test.go +++ b/apps/lib/data_provider/sources/skeleton/data_source_test.go @@ -6,4 +6,5 @@ import ( func TestSkeletonDataSource(t *testing.T) { // TODO: write some unit tests for your data source + t.Fatalf("implement me") }