Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar hover disabled due to crash when reading highlightedSidebarLayers #264

Open
ellbosch opened this issue Sep 7, 2024 · 0 comments

Comments

@ellbosch
Copy link
Contributor

ellbosch commented Sep 7, 2024

Repro steps:

  1. Remove the commented out code flagged by // TODO: reads here cause a crash nodes once connected to layer inputs nodes
  2. Create a patch node and any layer node (i.e. Oval layer node)
  3. Create a node for one of the layer node's inputs (i.e. the position input)
  4. Connect the patch node's output to the layer input node
  5. Open the left-hand sidebar and hover over an element

You'll notice an unsafe memory access crash when this happens.

Unclear why this happens with this exact criteria—the state gets set inside a SwiftUI .onHover. It appears that all reads and writes take place on the main thread.

@ellbosch ellbosch changed the title Crash caused by reading highlightedSidebarLayers with disconnected edge Sidebar hover disabled due to crash when reading highlightedSidebarLayers Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant