Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map overlapping in corridor and loop closed not working #134

Closed
casiarobot opened this issue Nov 27, 2019 · 6 comments
Closed

map overlapping in corridor and loop closed not working #134

casiarobot opened this issue Nov 27, 2019 · 6 comments

Comments

@casiarobot
Copy link

Hi,
Thanks for u last answer !

  • map overlapping in corridor
    slam toolbox do great at first, but overlapping
    with nothing changing at the same environment. Not only along the direction of corridor, vertical direction may sometimes happen.
  • another problem is that loop searching seems not working
    A square of 130*50 meters with rich features, I have tried many times and falied.

If needed I will upload the configurations and map later.

Thanks again!

@SteveMacenski
Copy link
Owner

I don’t understand your question or problem. Please upload your content and describe in more detail what you’re doing, what you expect, what your outcome is

@casiarobot
Copy link
Author

I think #112 can describe things that have happened! What the difference is that I run slamtoolbox in 'mapping' mode instead of 'localization' mode.
Below are the some maps 'loop searching' failed.

Screenshot_20191128_135630
Screenshot_20191128_135721
Screenshot_20191128_135901
Screenshot_20191128_135913
Screenshot_20191128_135933

@SteveMacenski
Copy link
Owner

SteveMacenski commented Nov 28, 2019

Your odometry looks exceptionally bad and there’s no reasonable expectation with the default settings to be searching for loops with that incredible amount of deviation.

Please tune your parameters, see the readme for descriptions, as well as tune your odometry. Overall I don’t look at this and see a bug unless there’s more going on here that I’m misunderstanding

Have you made an earnest attempt to tune this software for your platform?

@casiarobot
Copy link
Author

Thanks for you advices!
I make many tries these days,such as integrate odom->base_link tf with roll and pitch. However, when deeply read the src, I modify two parameters,

link_scan_maximum_distance: 6.0
loop_search_maximum_distance: 20.0
compared to ever:
link_scan_maximum_distance: 1.5
loop_search_maximum_distance: 3.0

and it works with the same bag data.
Figure is the new map and old.
new
test

However, the whole map fail loop closure. Slam toolbox become more and more slow in new scan data and new mapping area is sparely.
fail

@SteveMacenski
Copy link
Owner

SteveMacenski commented Dec 3, 2019

Again, I think your platform needs to focus on better odometry, that drift is really not great. There’s nothing this project is going to be able to do if the base properties don’t produce acceptable priors if you’re operating in large sparse spaces.

The values you had to increase are proportional to odometry quality. You increased the search space by over 6x, so it doesn’t surprise me that its getting slower. The best bang for your buck is to improve your odometry before looking for a slam solution. it doesn’t seem the odometry is suitable for the sparse environments you want to operate in.

@SteveMacenski
Copy link
Owner

SteveMacenski commented Dec 3, 2019

Closing ticket- no action items.

Spend some time to tune your platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants