Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add urlArgs support to {{#evl}} and {{#vlink}} #101

Closed
zealvurte opened this issue Sep 4, 2024 · 2 comments
Closed

Add urlArgs support to {{#evl}} and {{#vlink}} #101

zealvurte opened this issue Sep 4, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@zealvurte
Copy link

This is currently unsupported, limiting the usefulness of links vs individual embeds. Please can support be added.

The below looks to be the obstacle for this working, as currently it mangles the parsing of the urlArgs into being unusable and thus absent from the iframe config of the link.

$parts = array_map( 'trim', explode( '=', $value ) );

It should be changed to the following, if I'm not mistaken:

 	$parts = array_map( 'trim', explode( '=', $value, 1 ) );
@octfx octfx added the enhancement New feature or request label Sep 4, 2024
@octfx
Copy link
Member

octfx commented Sep 4, 2024

Thanks for the report!
I currently do not have access to my computer, would you mind opening a pr with your proposed change?

octfx added a commit that referenced this issue Sep 10, 2024
octfx added a commit that referenced this issue Sep 10, 2024
@octfx
Copy link
Member

octfx commented Sep 11, 2024

Implemented through comment in #102

@octfx octfx closed this as completed Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants