Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html.skin-citizen-dark doesn't work for Auto mode #877

Open
RothwellWiki opened this issue Jun 14, 2024 · 1 comment
Open

html.skin-citizen-dark doesn't work for Auto mode #877

RothwellWiki opened this issue Jun 14, 2024 · 1 comment
Labels
wontfix This will not be worked on

Comments

@RothwellWiki
Copy link

Describe the Bug

Objects I target with html.skin-citizen-dark don't change to their dark theme when on auto mode. Is this a bug or do I have to do add something like html.skin-citizen-auto to them too?

Auto
Dark

Steps to reproduce the behavior:

  1. Go to 'https://www.rothwell-leeds.co.uk/wiki/Main_Page' in your browser/device's dark mode
  2. Toggle from auto to dark
  3. See difference

Expected Behavior

Objects with html.skin-citizen-dark should change when in auto.

System

  • MediaWiki version: 1.41.0
  • Server OS: Unknown (hosted by Miraheze).
  • Installed extensions and versions: see Special:Version. Citizen 2.15.1 (dcd569f.) - although likely a much more recent version due to very slow updates to Special:Version.
  • PHP version: 8.2.18 (fpm-fcgi)
@RothwellWiki RothwellWiki added the bug Something isn't working label Jun 14, 2024
@alistair3149
Copy link
Member

Yes it is the intended behavior.
We refactored how theme classes are handled to align with the current standards in MediaWiki.
The skin-citizen-dark and the similar classes are getting deprecated and being replaced with the new skin-theme-clientpref- classes. You can see how they are being used on this page: https://www.mediawiki.org/wiki/Recommendations_for_night_mode_compatibility_on_Wikimedia_wikis

@alistair3149 alistair3149 added wontfix This will not be worked on and removed bug Something isn't working labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants