-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an image loading animation? #699
Comments
We used to have JS lazyloading years ago in the Citizen skin. However, it caused a lot of issues with many wikis so we ended up deferring to use the browser native method instead ( If anyone knows of a way, please feel free to drop a comment or submit a PR! |
https://starcitizen.tools/ It will delay the triggering of the load event |
I provide codes that can achieve fade in loading, which have significant limitations😣:
|
I found that the MobileFrontend comes with it, can use it directly on the desktop? Because many people don't use MobileFrontend. You can take a look if you have time🐣 |
I'm aware of the MF implementation and as I mentioned above, we had a similar implementation a long time ago. However, it was removed as the native browser implementation is more superior and has noscript support. It is unlikely that we will go back to the JS lazyload implementation, given that core already supports the native method. |
I'm not sure whether it is a bug, it seems to be exclusive to Microsoft Edge and only popping up recently. There's a relevant task that is being tracked: https://phabricator.wikimedia.org/T341480 Either way it is a MediaWiki core implementation and is unrelated to the Citizen skin, it is more suitable to submit the relevant info to that task. |
The Problem
The image loading in the article is very stiff, I hope create an image loading animation.
The Solution
Like Minerva, the image fades in. I think it's a good design.
You can also use image scrolling to lazily load.
The text was updated successfully, but these errors were encountered: