Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable collapsible sections does not influence the generated section html #623

Open
simontaurus opened this issue May 15, 2023 · 2 comments

Comments

@simontaurus
Copy link
Contributor

$wgCitizenEnableCollapsibleSections = false; disables the JS-functionality, but does not influence the generated section html (including the collapse-button).
I was wondering if it's possible to skip BodyContent:makeSections completely when $wgCitizenEnableCollapsibleSections = false;

private function makeSections( DOMDocument $doc, array $headingWrappers ) {

simontaurus added a commit to OpenSemanticLab/mediawiki-extensions-Reveal that referenced this issue May 16, 2023
@alistair3149
Copy link
Member

That's weird as the config should disable the formatter according to here. I'll look into it.

@alistair3149
Copy link
Member

Sorry for the late response, I totally forgot about it until someone mentioned it to me recently.
I am unable to reproduce it in the current version by setting $wgCitizenEnableCollapsibleSections = false;, would you be able to verify if it is still an issue for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants