Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID Anchor Link Issues #88

Open
Vishkujo opened this issue Apr 28, 2023 · 6 comments
Open

ID Anchor Link Issues #88

Vishkujo opened this issue Apr 28, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@Vishkujo
Copy link

When linking to an ID anchor link of a div that is inside a tab, it removes everything else from the tab.

Here's an example. It removed the "Crazy Diamond" box above "Crazy Diamond Second", and only shows the latter one while leaving a large gap underneath it.

@alistair3149
Copy link
Member

Is this still reproducible? I don't see the issue on the site.

@Vishkujo
Copy link
Author

Vishkujo commented Jul 6, 2023

Yup, I still have the issue. Seems to differ depending on the browser you use. For some reason in Firefox, clicking the link doesn't do anything with the anchor unless you manually press enter in the address bar again.

Here are some pic examples:

  • Default page without any anchor link - Both "Josuke Higashikata" and "Josuke Higashikata Second" are visible
  • Firefox with anchor link - Anchor link is for "Crazy Diamond Second". It shows the Crazy Diamond Second div by itself while the regular "Crazy Diamond" box which is normally above it is hidden. Also the tab shows that Josuke Higashikata (the default tab) is selected instead of Crazy Diamond.
  • Chrome with anchor link - Anchor link is for "Crazy Diamond Second", but it's showing "Josuke Higashikata Second" by itself with the regular "Josuke Higashikata" box hidden.

@alistair3149
Copy link
Member

Hi sorry for getting back late. Does it still happen in the latest version?

@Vishkujo
Copy link
Author

Yeah, I still get the issue. I tested it on the Star Citizen wiki just to make sure it wasn't my CSS or JavaScript causing the issue.
Steps to reproduce:

  1. Check this page
  2. Click the "Crazy Diamond" tab
  3. Click "Expand" on either the "Crazy Diamond" box's Gallery or the "Crazy Diamond Second" box's Gallery. You'll see that when the gallery expands, the boxes don't fit within the tabber panel anymore (the bottom gets cut off).
  4. Try clicking "Link to this section" on the "Crazy Diamond Second" box. The panel will scroll to the bottom, cutting off the top of the first box. (this one doesn't seem to happen on Chrome, the anchor does nothing there for some reason, but it happens on Firefox)

Video example

It seems like the problem might be related to the height of tabber__panel. It might need to recalculate height if the content inside it changes?

@alistair3149
Copy link
Member

Ooooh I finally get it. Yes it is a known issue that I have been trying to fix over the last few weeks. Somehow the resize observer is not working correctly on the tabpanels, which prevents the tabpanels changing its height according to the content. I'll give it another try next week and see if I can patch it.

@alistair3149
Copy link
Member

Can you still reproduce the issue now with the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants