Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default selected tab is transcluded into the page, which results in some issues #106

Open
chixvv1 opened this issue Oct 18, 2023 · 1 comment

Comments

@chixvv1
Copy link
Contributor

chixvv1 commented Oct 18, 2023

Default selected tab is transcluded into the page (this line).

As a result, in the mobile view, sections in the default selected tab cannot be collapsed. For example, this page.

And the contents in the default selected tab are searchable during searching, which is inconsistent with unselected tabs. Which is annoying for wiki maintainer.

The expected behavior is that all tabs are loaded using JavaScript, and the default selected tab loads when loading page, while other tabs load when clicking their tab label.

@alistair3149
Copy link
Member

The other pages are lazyloaded because of the performance impact. Each page tab can contain a large amount of HTML and also additional network request to a page.

The default selected page is loaded in PHP so that it can be cached and avoiding layout shift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants