NAMECHEAP: Fix integration tests

[tlimoncelli]

As reported in #3311 (comment) ... here are 5 integration tests that are failing.

--- FAIL: TestDNSProviders/willpower232testsdnscontrol.com/06:MX:Change_MX_p (0.95s)
--- FAIL: TestDNSProviders/willpower232testsdnscontrol.com/22:complex_TXT:a_0-byte_TXT (0.75s)
--- FAIL: TestDNSProviders/willpower232testsdnscontrol.com/33:CAA:CAA_change_flag (0.89s)
--- FAIL: TestDNSProviders/willpower232testsdnscontrol.com/76:IGNORE_with_modify:VERIFY_PREVIOUS (0.46s)
--- FAIL: TestDNSProviders/willpower232testsdnscontrol.com/79:IGNORE_w/change_b3227:VERIFY_PREVIOUS#02 (0.30s)

@willpower232

[willpower232]

I think the Change MX P is #2277

I will investigate your fix as per #3311 (comment) and see what information I can gather about the others

[tlimoncelli]

Thanks!

[willpower232]

Copying the output from previous test runs

33

=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/33:CAA:CAA_record
    integration_test.go:291: 
        GENERATE_ZONE: willpower232testsdnscontrol.com (1 records)[
        + CREATE CAA willpower232testsdnscontrol.com 0 issue "letsencrypt.org" ttl=300]
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/33:CAA:CAA_change_tag
    integration_test.go:291: 
        GENERATE_ZONE: willpower232testsdnscontrol.com (1 records)[
        ± MODIFY CAA willpower232testsdnscontrol.com: (0 issue "letsencrypt.org" ttl=300) -> (0 issuewild "letsencrypt.org" ttl=300)]
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/33:CAA:CAA_change_target
    integration_test.go:291: 
        GENERATE_ZONE: willpower232testsdnscontrol.com (1 records)[
        ± MODIFY CAA willpower232testsdnscontrol.com: (0 issuewild "letsencrypt.org" ttl=300) -> (0 issuewild "example.com" ttl=300)]
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/33:CAA:CAA_change_flag
    integration_test.go:291: 
        GENERATE_ZONE: willpower232testsdnscontrol.com (1 records)[
        ± MODIFY CAA willpower232testsdnscontrol.com: (0 issuewild "example.com" ttl=300) -> (128 issuewild "example.com" ttl=300)]
    integration_test.go:312: Expected 0 corrections on second run, but found 1.
    integration_test.go:314: UNEXPECTED #0: GENERATE_ZONE: willpower232testsdnscontrol.com (1 records)[
        ± MODIFY CAA willpower232testsdnscontrol.com: (0 issuewild "example.com" ttl=300) -> (128 issuewild "example.com" ttl=300)]

I'm guessing if they still struggle with MX priority then fiddling with flags on CAA isn't far off 🙃

76

=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/76:IGNORE_with_modify:Create_some_records
    integration_test.go:291: 
        GENERATE_ZONE: willpower232testsdnscontrol.com (8 records)[
        + CREATE A foo.willpower232testsdnscontrol.com 1.1.1.1 ttl=300 
        + CREATE A foo.willpower232testsdnscontrol.com 10.10.10.10 ttl=300 
        + CREATE AAAA foo.willpower232testsdnscontrol.com 2003:dd:d7ff::fe71:aaaa ttl=300 
        + CREATE MX foo.willpower232testsdnscontrol.com 10 aspmx.l.google.com. ttl=300 
        + CREATE MX foo.willpower232testsdnscontrol.com 20 alt1.aspmx.l.google.com. ttl=300 
        + CREATE A zzz.willpower232testsdnscontrol.com 3.3.3.3 ttl=300 
        + CREATE A zzz.willpower232testsdnscontrol.com 4.4.4.4 ttl=300 
        + CREATE AAAA zzz.willpower232testsdnscontrol.com 2003:dd:d7ff::fe71:cccc ttl=300]
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/76:IGNORE_with_modify:IGNORE_change_ByZone
    integration_test.go:291: 
        GENERATE_ZONE: willpower232testsdnscontrol.com (6 records)[
        ± MODIFY A foo.willpower232testsdnscontrol.com: (10.10.10.10 ttl=300) -> (11.11.11.11 ttl=300)]
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/76:IGNORE_with_modify:VERIFY_PREVIOUS
    integration_test.go:280: Expected 0 corrections on FIRST run, but found 2.
    integration_test.go:282: UNEXPECTED #0: GENERATE_ZONE: willpower232testsdnscontrol.com (8 records)[
        + CREATE A zzz.willpower232testsdnscontrol.com 3.3.3.3 ttl=300 
        + CREATE A zzz.willpower232testsdnscontrol.com 4.4.4.4 ttl=300]
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/Clean_Slate:Empty#37
    integration_test.go:291: 
        GENERATE_ZONE: willpower232testsdnscontrol.com (0 records)[
        - DELETE A foo.willpower232testsdnscontrol.com 1.1.1.1 ttl=300 
        - DELETE A foo.willpower232testsdnscontrol.com 11.11.11.11 ttl=300 
        - DELETE AAAA foo.willpower232testsdnscontrol.com 2003:dd:d7ff::fe71:aaaa ttl=300 
        - DELETE MX foo.willpower232testsdnscontrol.com 10 aspmx.l.google.com. ttl=300 
        - DELETE MX foo.willpower232testsdnscontrol.com 20 alt1.aspmx.l.google.com. ttl=300 
        - DELETE AAAA zzz.willpower232testsdnscontrol.com 2003:dd:d7ff::fe71:cccc ttl=300]

79

=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/79:IGNORE_w/change_b3227:Create_some_records
    integration_test.go:291: 
        GENERATE_ZONE: willpower232testsdnscontrol.com (2 records)[
        + CREATE A testdefined.willpower232testsdnscontrol.com 9.9.9.9 ttl=300 
        + CREATE A testignore.willpower232testsdnscontrol.com 8.8.8.8 ttl=300]
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/79:IGNORE_w/change_b3227:ignore
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/79:IGNORE_w/change_b3227:VERIFY_PREVIOUS
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/79:IGNORE_w/change_b3227:Verify_nothing_changed
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/79:IGNORE_w/change_b3227:VERIFY_PREVIOUS#01
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/79:IGNORE_w/change_b3227:ignore_with_change
    integration_test.go:291: 
        GENERATE_ZONE: willpower232testsdnscontrol.com (1 records)[
        ± MODIFY A testdefined.willpower232testsdnscontrol.com: (9.9.9.9 ttl=300) -> (2.2.2.2 ttl=300)]
=== RUN   TestDNSProviders/willpower232testsdnscontrol.com/79:IGNORE_w/change_b3227:VERIFY_PREVIOUS#02
    integration_test.go:280: Expected 0 corrections on FIRST run, but found 1.
    integration_test.go:282: UNEXPECTED #0: GENERATE_ZONE: willpower232testsdnscontrol.com (2 records)[
        + CREATE A testignore.willpower232testsdnscontrol.com 8.8.8.8 ttl=300]

[willpower232]

I can confirm rejectif.TxtIsEmpty skipped 22 as presumably expected. 76 still errored but it crapped out at 78 so I didn't get to see if 79 was still a problem.

Is it possible to just run a single test in isolation?

[tlimoncelli]

Yup! Add -start 4 -end 10 to run test 4 thru 10 inclusive (for example).