-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposed change: ProbeType
class
#24
Comments
@bendichter @oruebel @rly Thanks for the suggestions.
|
Just a quick note, to make the logic of this consistent, we were considering to potentially deprecate
As far as I recall, the
In principle, the information of which contacts are being used should be encoded in the At first glance, I think it makes sense to have |
Ping @mavaylon1 |
Hi Ryan, |
@oruebel @rly and I reviewed this and worked through how it would be integrated with the core schema.
One of the shortcomings of the extension as is, is that you would have a lot of repeated information if you have a bunch of the same probe. Consider an experiment with 5-6 NP probes implanted simultaneously- each one would need to duplicate the exact same ContactTable. Instead, we could create a new type,
ProbeType
, which contains information about the probe model, e.g. contact table, geometry of shank information, manufacturer. TheProbe
object would have an optional attributeprobe_type
which would link to aProbeType
object. TheProbe
class would also contain metadata about a specific probe object, e.g. the serial number.Another change the addition of
Shank
objects, which are contained within aProbeType
. The optionalshank
column of theContactTable
is an object reference to one of the shanks in thatProbeType
. This would allow users to extend theShank
class to add custom metadata to shanks.The text was updated successfully, but these errors were encountered: