Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search for topic #142

Closed
tomas12 opened this issue Mar 1, 2019 · 9 comments
Closed

search for topic #142

tomas12 opened this issue Mar 1, 2019 · 9 comments

Comments

@tomas12
Copy link

tomas12 commented Mar 1, 2019

Hi, your app is really cool. What I miss is a possibility to search and remove topics. When testing we are dealing with many topics and this would make life more easier. Thanks!

@Crim
Copy link
Collaborator

Crim commented Mar 2, 2019

So you'd like a search option added here to quickly locate topics? And then the possibility to remove topics?

image

@tomas12
Copy link
Author

tomas12 commented Mar 11, 2019

Yes that would be great. Deletion could work like the one at the Consumer Group (on the right side). And especially when dealing with many topics a search would be also very helpful

@midN
Copy link

midN commented Mar 14, 2019

If you ever go implementing the delete/management features, can we get roles in place please @Crim ?
Would be lovely to have a read-only role

@Crim
Copy link
Collaborator

Crim commented Mar 19, 2019

Yea that's definitely a concern. I've been trying to keep all of the features so far non-destructive.

I've got an initial implementation for this in PR #150 where deleting a topic requires the Administrator credential. Unsure if I should hold back the removing functionality until we have more fine grained control over roles/abilities.

@midN
Copy link

midN commented Mar 19, 2019

@Crim Thanks for working on this 👍 I'd vote that roles is a must for any future destructive changes as there is kafka-manager from yahoo for destructive-only action and this is basically the only app on market that allows to give easy read-only access for teams to view data without killing the kafka

@tomas12
Copy link
Author

tomas12 commented Mar 20, 2019

Thank you too for working on this!

@Crim
Copy link
Collaborator

Crim commented Mar 20, 2019

I've added searching to a few spots under the 'Cluster Explorer' section of the application.

While its now implemented, I think I'm going to hold back the removal of topics until custom user roles is released. I've got that started in a separate ticket, but not entirely sure how long before that work will be complete.

@Crim
Copy link
Collaborator

Crim commented Mar 20, 2019

I've created #157 to track deletion of topics.

@Crim Crim changed the title remove/search for topic search for topic Mar 20, 2019
@Crim
Copy link
Collaborator

Crim commented Mar 20, 2019

Released in 2.2.0

@Crim Crim closed this as completed Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants