-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Re-opening] All products appear in each category when category filter disabled (2.4 only) #3506
Comments
@vahonc could you try to reproduce in both community and enterprise versions and in both developer and production mode ? |
@rbayet, I will try to reproduce this issue again. BR, |
Not reproduced on https://demo.magento-elastic-suite.io/index.php/venia-bottoms.html Which is on Magento 2.4.7-p2 and ElasticSuite 2.11.x branch. I highly suspect this is a project specific issue, or linked to third-party modules. I let you try to reproduce as well @vahonc |
is_anchor = 0? |
perhaps... good question anyway :) |
@rbayet : sorry if my comment cause you such unhappiness. You did notice the question mark mate? I was literally asking if this bug still exists in 2025, to which another user confirmed. Did I not fluff the text up enough for you? My next step would have been to raise a new ticket, after that confirmation. Maybe be less sensitive, and walk away from the keyboard until you calm down. Things might go smoother.. Remember we have timezones.... Don't come to Australia mate, we kinda speak direct here, and you'd not likely make it a day, being such an sensitive person. I'll just chalk it off on you having a bad day, and move on. You just got to quick on your high horse to allow this to progress to a new ticket, which I would have opened, if you have given some time, but you'd rather attack. Not very professional. It was literally posted yesterday, asking my question. You just seem to perceive it as aggressive, as you must be having a bad day. |
Now, with all the unpleasantness out the way.... I can confirm I cannot reproduce this in latest luma vanilla install. |
@romainruaud fwiw, I am not sure if is_anchor is part of the problem, as it is not display products from all children, just simply not adding any form of category filter I have the issue with / and without is_anchor in play This is what I had found whilst investigating So, for some reason the filters are doing the oposite, asking for all prodicts NOT in the current category. |
The tone of your comment and the tone of the direct slack message you send @romainruaud did. |
The query portion in your screenshot is expected to be there, on it own it's not requiring all the products NOT in category 64, it's simply asking to reject all products which are assigned to category 64 AND are blacklisted there. Here's the structure of a query for a physical category (category Gear / Bags on a Luma) : Here are the details of each part So your issue will most likely reside in the green part / the first clause of the query/filter. Possible solutions to all products being visible in your category 64
Concerning the last point, we've introduced in releases https://github.com/Smile-SA/elasticsuite/releases/tag/2.11.8.3 and https://github.com/Smile-SA/elasticsuite/releases/tag/2.10.22.3 a setting (enabled by default) that prevents the rule engine to generate an non-existent / empty clause for disabled categories which would lead to all products being visible
If that's not the case it could be an issue related to the internal conditions caching of the virtual categories rule engine. In the meantime, please post the exact Elasticsuite version used in the environment where you initially saw that problem. Here is the corresponding full request for my example from above
|
Not virtual categories. I tested this nearly 28 days ago, and I am sure I did this with zero other module present. That woudl be a first logical step to have tested, so i am fairly confident it is not related to another module. I highly suspect config/setup. I am attempting to reproduce the issue in such a setup again. PS: this is not occurring on a live site, this is a migration WIP from m1 I am, however quite ill, so will likely get back to it later. |
If you're migrating from m1, then a frequent issue would be the "is_anchor" category attribute (which Elasticsuite hides from the category edit screen) not being properly set to "1" for every existing category. In an upcoming release, we'll introduced "Healthchecks" and checking that all categories are correctly set to is_anchor=1 might be such a healthcheck to perform. Regards, |
Unfortunately the whole is_anchor = 1 to display all child products in a top level categories goes against the site curated product lists. My end goal is to use the virtual category feature, as the m1 site is heavily based on a m1 dynamic category product module. I had also initially thought this was the issue. The site does not use layered navigation in any way. I did check that everything was set to 1, and problem remained. For now, due to time constraints, as I need to actually work on billable work, i am likely only going to get back to this much later. The site uses a very very custom catalog layout. https://www.ntotank.com/vertical-water-tanks Yes, I did consider that as the issue, but the collection gathered incorrectly comes into play way before frontend rendering. Since my next few days will be spent working on the virtual categories and transposing the m1 dynamic rules to m2 virtual categories, I will be keeping attention onto this issue, and hope I see something that is of interest. |
I did the following: Using a sanatized client db, I disabled all 3rd party modules and code in client site, and set theme to luma
reindexed.
Disabled all cache, so it does not affect any results.
I then loaded 3 categories in frontend. Next I installed elasticsuite, and enabled selective parts thereof.
confirmed is set reindexed reviewed the same categories. as can be seen, all categories now sport all products in the catalog. |
confirmation on active modules:
I can pass you this dataset to test on, if that will help you debug this. |
@romainruaud @rbayet see previous comment, showing issue on client database, with only elasticsuite module(s) active. |
It seems the issue #1925 can still be encountered even with the fix created in #2067.
Preconditions
Magento Version : 2.4.7-p2
ElasticSuite Version : 2.11.10
Environment : ??
Third party modules : ??
The text was updated successfully, but these errors were encountered: