Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incidencia - Encuestas - Al duplicar una encuesta se duplican las preguntas en la encuesta duplicada #91

Open
ManuSinergiaCRM opened this issue Jan 29, 2024 · 1 comment · May be fixed by #483
Open

Incidencia - Encuestas - Al duplicar una encuesta se duplican las preguntas en la encuesta duplicada #91

ManuSinergiaCRM opened this issue Jan 29, 2024 · 1 comment · May be fixed by #483
Assignees
@ainaraRT
Labels
bug Something isn't working Encuestas not urgent

Comments

@ManuSinergiaCRM
Copy link
Collaborator

ManuSinergiaCRM commented Jan 29, 2024 •
edited
Loading

Descripción del problema
Se comprueba que si tenemos un FdT:

  • Módulo base: Encuestas
  • Ejecutar al guardar
  • Registros nuevos
  • Acción:
    • Modificar la propia encuesta, por ejemplo, pasar de estado borrador a publicado.
    • Calcular campos, por ejemplo, calcular el nombre.

Al duplicar una encuesta, en la encuesta duplicada tendremos también duplicadas las preguntas.

Preguntas de encuesta duplicadas

Información

  • No he podido probarlo en la versión 7.12.12 de SuiteCRM ya que al ir al commit de dicha versión no funciona y no he podido investigar que sucede.
  • En SuiteCRM 7.14.2 no se reproduce la incidencia.
@ManuSinergiaCRM ManuSinergiaCRM added bug Something isn't working Encuestas not urgent labels Jan 29, 2024
@AlbertoSTIC
Copy link
Collaborator

SinergiaCRM/modules/Surveys/Surveys.php

Lines 153 to 199 in 4e20ca4

if (($_POST["duplicateSave"] && $_POST["duplicateSave"]="true"))
{
unset($_REQUEST['survey_questions_ids']);
}
// STIC End
$res = parent::save($check_notify);
if (empty($_REQUEST['survey_questions_supplied'])) {
return $res;
}
foreach ($_REQUEST['survey_questions_names'] as $key => $val) {
if (!empty($_REQUEST['survey_questions_ids'][$key])) {
$question = BeanFactory::getBean('SurveyQuestions', $_REQUEST['survey_questions_ids'][$key]);
// STIC-Custom 20211110 AAM - With deleted questions, call mark_deleted and skip the loop
// STIC#457
if ($_REQUEST['survey_questions_deleted'][$key]) {
$question->mark_deleted($question->id);
continue;
}
// END STIC
} else {
$question = BeanFactory::newBean('SurveyQuestions');
}
$question->name = $val;
$question->type = $_REQUEST['survey_questions_types'][$key];
$question->sort_order = $_REQUEST['survey_questions_sortorder'][$key];
$question->survey_id = $this->id;
$question->deleted = $_REQUEST['survey_questions_deleted'][$key];
$question->save();
// STIC-Custom 20211110 AAM - Removing the "s" from the word question(s)
// STIC#457
// if (!empty($_REQUEST['survey_questions_options'][$key])) {
// $this->saveOptions(
// $_REQUEST['survey_questions_options'][$key],
// $_REQUEST['survey_questions_options_id'][$key],
// $_REQUEST['survey_questions_options_deleted'][$key],
if (!empty($_REQUEST['survey_question_options'][$key])) {
$this->saveOptions(
$_REQUEST['survey_question_options'][$key],
$_REQUEST['survey_question_options_id'][$key],
$_REQUEST['survey_question_options_deleted'][$key],
$question->id
);
}
}
return $res;

Seguramente este código sea el causante de duplicar las preguntas. Se debería ver qué condición se podría aplicar/eliminar para que no ejecute dos veces la función.

@AlbertoSTIC AlbertoSTIC assigned ainaraRT and unassigned AlbertoSTIC Aug 13, 2024
@ainaraRT ainaraRT linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainaraRT ainaraRT

Labels
bug Something isn't working Encuestas not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hotfix - Encuestas - Duplicación de preguntas mediante un flujo de trabajo SinergiaTIC/SinergiaCRM
3 participants
@AlbertoSTIC @ManuSinergiaCRM @ainaraRT