Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment issue on mobile devices #10

Open
1 task
Gizmotronn opened this issue Oct 18, 2021 · 1 comment
Open
1 task

Alignment issue on mobile devices #10

Gizmotronn opened this issue Oct 18, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Gizmotronn
Copy link
Member

See #8 link

First:

  • Hamburger menu has nothing in it on mobile devices unless you're logged in (thus creating a redundant eyesore)
  • Let's try and alter the hamburger menu to only show for logged-in users

Then fix the general alignment issue @artpassos

@Gizmotronn Gizmotronn added the bug Something isn't working label Oct 18, 2021
@Gizmotronn
Copy link
Member Author

Just now I've fixed the issue with the hamburger menu showing up for all users
I want to fix this code later (fix the commenting alignment ) so that the Models section shows up inside the hamburger menu but I'll do this later

<div class="collapse navbar-collapse" id="navbarSupportedContent">
                <ul class="navbar-nav ml-auto">
                    <li class="nav-item">
                        <a class="nav-link" href="index.html"><!--🏡 Home</a>
                    </li>
                    <li class="nav-item">
                        <a class="nav-link" href="http://dev.to/gizmotronn"><!--✍🏻 Press Releases</a>
                    </li>
                    <li class="nav-item">
                        <a class="nav-link" href="#/ms/login" data-ms-content="!members">🔑 Login</a>
                    </li>
                    <!--
                    <li class="nav-item dropdown">
                        <a class="nav-link dropdown-toggle" data-toggle="dropdown" href="#" role="button"
                            aria-haspopup="true" aria-expanded="false">Works</a>
                        <div class="dropdown-menu">
                            <a class="dropdown-item" href="showcase.html">Showcase Parallax</a>
                            <a class="dropdown-item" href="showcase4.html">Showcase Carousel</a>
                            <a class="dropdown-item" href="showcase3.html">Showcase Circle</a>
                            <a class="dropdown-item" href="works.html">Portfolio Masonry</a>
                            <a class="dropdown-item" href="works2.html">Portfolio Filtering</a>
                            <a class="dropdown-item" href="works3.html">Portfolio Gallery</a>
                        </div>
                    </li>-->
                    <li class="nav-item dropdown">
                        <a class="nav-link dropdown-toggle" data-toggle="dropdown" href="#" role="button" 
                            aria-haspopup="true" aria-expanded="false" data-ms-content="members">⛓ Models</a> <!--Remove dropdown arrow-->
                        <div class="dropdown-menu">
                            <a class="dropdown-item" href="#ms-login">🔑 Login</a>
                            <a class="dropdown-item" href="https://3.basecamp.com/5181697/projects">⛺️ Basecamp</a>
                            <a class="dropdown-item" href="#">📑 Documentation</a> <!--Put jekyll in here (this repo underneath `docs' folder) -->
                            <a class="dropdown-item" href="keybase://chat/signalkinetics#general/41">💬 Keybase</a>
                            <a class="dropdown-item" href="#/ms/profile">👩🏻‍🚀 Profile</a>
                            <a class="dropdown-item" href="https://signal-k.slack.com/archives/C02GSLFB05N/p1634270045000500">#️⃣ Slack</a>
                            <a class="dropdown-item" href="https://github.com/signal-k">🙀 Github</a>
                            <a class="dropdown-item" href="http:

Gizmotronn added a commit that referenced this issue Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants