Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

children/childprops used inconsistently #13

Open
Sigfried opened this issue Jan 2, 2017 · 1 comment
Open

children/childprops used inconsistently #13

Sigfried opened this issue Jan 2, 2017 · 1 comment
Labels
enhancement

Comments

@Sigfried
Copy link
Owner

Sigfried commented Jan 2, 2017

For instance: https://github.com/Sigfried/supergroup/blob/master/supergroup.js#L373 and line 377. Should get rid of both and use a common method, getChildren that returns val[childprop]. Also do same with parent (which will resolve #5).
@Sigfried
Copy link
Owner Author

Sigfried commented Jan 2, 2017

Added getChildren and hasChildren in 4749d01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sigfried