Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically derive as many traits as possible for KeyCode, and other public structs #8

Open
Neurrone opened this issue Sep 9, 2018 · 2 comments

Comments

@Neurrone
Copy link

Neurrone commented Sep 9, 2018

As per title. Ran into this because I have a Keycode in a struct representing possible input gestures, and was unit testing configuration parsing.

SiegeLord pushed a commit that referenced this issue Sep 14, 2018
Addresses some of #8.
@SiegeLord
Copy link
Owner

I added some. Keeping this open in case I forgot some.

@Neurrone
Copy link
Author

Thanks. I also ran into a situation where I missed being able to hash it.

If you also add automatic derives for hash, it would make sense to derive as many as possible so it would hopefully be the last time you have to do this, as suggested by this page on common traits in the API guidelines.

@Neurrone Neurrone changed the title #derive(Debug)] for KeyCode, and other public structs Automatically derive as many traits as possible for KeyCode, and other public structs Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants