Pass --safe to RuboCop

[dmke]

I'm running robocop --safe on the CI. This has lead to the situation, where the CI started failing after VSCode/ruby-lsp started complaining about the following line:

user = User.find_by_password_reset_token(params[:token])

• ruby-lsp and bundle exec rubocop (without --safe) report

  Rails/DynamicFindBy: Use find_by instead of dynamic find_by_password_reset_token.

• bundle exec rubocop --safe doesn't report a problem.

(N.B. #find_by_password_reset_token is defined by Rails' has_secure_password. This might be a false positive from RuboCop, but I have other examples, like Rails/RakeEnvironment on Rake tasks which don't need to load the app environment.)

After disabling the line:

user = User.find_by_password_reset_token(params[:token]) # rubocop:disable Rails/DynamicFindBy

• ruby-lsp and bundle exec rubocop (without --safe) don't report a problem.

• bundle exec rubocop --safe reports

  Lint/RedundantCopDisableDirective: Unnecessary disabling of Rails/DynamicFindBy.

How do I configure ruby-lsp to pass --safe to RuboCop?

[andyw8]

👋 You would need to look up the syntax, but there should be away to enable the --safe option in your .rubocop.yml config, which would then be applied to both Ruby LSP and your CI.

[dmke]

I thought so too, but neither the docs (Ctrl+F, "safe"), nor the RuboCop defaults (under AllCops) have something in that direction.

(Me being blind is a possibility, of course 😄)

[andyw8]

I suggest opening an issue on the RuboCop repo, that seems like an unintentional omission.

[dmke]

FYI: rubocop/rubocop#13649

[dmke]

The solution is to add the desired CLI arguments to a file named .rubocop, i.e.

$ echo '--safe' >> .rubocop