Improve integration mapping chain resolution #526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
Improves integration integration mapping chain resolution:
Changes
#517 introduced automatic resolution of integration mappings to the current taxonomy, taking into account all newer mappings.
While working on #525, we discovered a flaw in that behaviour: subsequent mappings were only taken into account if they appeared in the next immediate version, but not versions after that. For example,
2022-02
would take into account mappings from2024-07
, but not2024-10
.We also discovered that in case a category fails to be resolved through this process, the error message is cryptic and not actionable.
This PR: