Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integration definitions with new mapping behaviour #525

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update integration definitions with new mapping behaviour #525

wants to merge 4 commits into from
+2,080 −54

Conversation

danielpgross
Copy link
Collaborator

@danielpgross danielpgross commented Jan 8, 2025 •
edited
Loading

Updates integration definitions according to the new mapping resolution behaviour introduced in #517 -- Shopify taxonomy mappings are now defined from one version relative to the next immediate one, instead of relative to the latest version.

  • Updates existing mapping definitions to follow the new format
  • Adds 2024-10 Shopify mappings
  • Adds new dist files generated from updated definitions
  • Updates mapping integration test expectations according to new format

@danielpgross Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ricardotejedorsanz
Copy link
Contributor

Thx @danielpgross 🙏

fd5203e Adding remaining mappings with new behaviour:

@danielpgross danielpgross mentioned this pull request Jan 10, 2025
Merged
@ricardotejedorsanz ricardotejedorsanz force-pushed the 01-08-update_integration_definitions_with_new_mapping_behaviour branch from fd5203e to fc74da8 Compare January 10, 2025 17:17
@danielpgross danielpgross marked this pull request as ready for review January 10, 2025 20:52
elsom25
elsom25 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@elsom25 elsom25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structural changes good — I do have some questions on the mappings themselves I'd like to review before we cut the version release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsom25 elsom25 elsom25 approved these changes

@tylerrowsell tylerrowsell Awaiting requested review from tylerrowsell

@chesterbot01 chesterbot01 Awaiting requested review from chesterbot01

@Catherine-Fu Catherine-Fu Awaiting requested review from Catherine-Fu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielpgross @ricardotejedorsanz @elsom25