PHP 8 support?

[dretsa]

Is PHP 8 support planned for this repository? I am willing to help support it.

The main changes we need to look out for are listed here: https://stitcher.io/blog/new-in-php-8 under "Breaking changes".

[glensc]

Similar progress in zf1s/zf1:

• iconv_substr behaves differently under PHP8 zf1s/zf1#31
• PHP8.0 compatibility patch zf1s/zf1#32

[Shardj]

Yeah it's absolutely planned, I'll reopen this though until it's supported

[glensc]

x-ref:

• [php 8.0] Add clarifying parens for nested ternary operation zf1s/zf1#39

you should read instructions how to backport from the other repos:

• Merge with zf1s #96 (comment)

[jeanmod]

some news about php 8 support ?

[onlime]

@Shardj Thanks for this great project! Can I donate somewhere to motivate you a bit working on PHP 8 support? :)

[onlime]

@Shardj let's discuss the licensing/donation thing later (I definitely want to donate something...). Just want to let you know that I am currently working on a small PR which should be ready shortly. I am doing some 3-way-diff of zf1s/zf1 monorepo (compiled all packages into library/Zend/), my own patched zf1 1.12.20, and your master branch.

I will not find time to dig deep into it, as it's impossible to review all diffs between shardj/zf1-future and zf1s/zf1 (even after automated PhpStorm refactoring of all traditional into short array syntax and ignoring all whitespace diff). But after some small fixes, my rather large project (which uses at least a third of all ZF1 components) already seems to work 100% on PHP 8.0.2

[Shardj]

@onlime awesome stuff, sounds like a huge step towards PHP 8 support for this repo

[onlime]

@Shardj here you go, #130 is mainly @Megatherium's work and it's not yet merged into zf1s/zf1 master. But I have reviewed all changes and they all make sense. Again, my project that uses quite a lot of ZF1 components runs perfectly fine under PHP 8.0.2 and I am going to run this in production as soon as you merge it, so I would quickly notice any problems.

[Shardj]

It's out on release-1.19.0 @onlime

Enjoy!

[onlime]

Great, thanks. But please note that I was not able to run unit tests. If you can get them running please do so and let me know of any problems. Please also update .travis.yml and get it running under PHP 8.

[Shardj]

Just created #131 as a reminder to myself to get on that

[onlime]

Hey @Shardj, just want to let you know that my rather large legacy ZF1 project is now running perfectly fine for 5 days in production on PHP 8.0 without a single issue!

It's a webhosting controlpanel/dashboard for my customers, so it's a rather complex project that uses ~ 30% of all ZF1 components. We're working on the next-gen customer dashboard which is going to be based on Laravel api backend with Vue.js/Nuxt frontend. But until that's ready, it will all still run on zf1-future. I am so glad you were supporting me getting those fixes for PHP 8 released. I have switched my whole dev environment to PHP8-only, which makes my life even a bit happier than it already is.

Please don't close this issue yet until tests run fine and while we still try to keep up with zf1s/zf1#51

[onlime]

3.5 months later, still no single issue with PHP 8.0. @Shardj please consider closing this issue. Or are you still planning to update tests to PHP 8 / migrate to Github actions?