Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[to fix] issue with in internal path #83

Open
Snowbaha opened this issue Nov 16, 2021 · 1 comment
Open

[to fix] issue with in internal path #83

Snowbaha opened this issue Nov 16, 2021 · 1 comment

Comments

@Snowbaha
Copy link

Snowbaha commented Nov 16, 2021

Hello,

I noticed I have lot of queries since I installed the plugin whereas I was thinknig it should be only check one time the url to redirect.

image

The issue comes internal paths, at first, I added a condition on : RedirectionPathResolver with someting like

if(false === strpos($source, '/_fragment/')){
//do the stuff
}

but there is lot of sources with this issue ('wishlist' (wishlist bundle) , 'block' / 'section' / 'page' (CMS bundle).

What is the best way to catch the good one to redirect (at home it should be "/") and not all the internal path render wiht controllers?

The best way should be to detect the good request but when I compare the Symfony\Component\HttpFoundation\Request, there is no way to know the good one.

Maybe add a paramter to excludes somes routes?

@loevgaard
Copy link
Member

Not sure I completely understand the issue. Could you elaborate a bit or explain a more elaborate example of something unexpected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants