Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version uplift needed in model_processing examples needed? #51

Closed
josor001 opened this issue Dec 17, 2021 · 4 comments
Closed

Version uplift needed in model_processing examples needed? #51

josor001 opened this issue Dec 17, 2021 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@josor001
Copy link
Collaborator

josor001 commented Dec 17, 2021

Because our sonatype repository is currently down and I wanted to do a local build, I just noticed that the dependency versions in https://github.com/SeelabFhdo/lemma/tree/main/examples/model-processing are still sitting at LEMMA v0.8.0 (build crashed cause v0.8.0 were not accessible locally nor from the temporary down repo). The build will work again when the sonatype repo is back up, however, this made me curious if we need/should do a version uplift to 0.8.5 for those model processing examples?
This may also concern other projects in the examples folder.

@josor001 josor001 added bug Something isn't working question Further information is requested labels Dec 17, 2021
@frademacher
Copy link
Collaborator

Yes, this is by intent. The model processor example at https://github.com/SeelabFhdo/lemma/tree/main/examples/model-processing documents the approach to implement model processors with LEMMA's model processing framework prior to its refactoring in version 0.8.5-SNAPSHOT. This circumstance is also indicated by the first lines of the example processor's README:

Note that this example project only serves documentary purposes for the implementation of model processors prior to the refactoring of LEMMA's model processing framework with LEMMA release 0.8.5-SNAPSHOT. For the latest approach on how to implement model processors leveraging the framework, please have a look at the example project model-processing-latest.

More precisely, this example project for LEMMA version 0.8.0-SNAPSHOT exists mainly for historical reasons and as additional information to Issue #42. However, since we have the refactored version of the framework at hand now (cf. https://github.com/SeelabFhdo/lemma/tree/main/examples/model-processing-latest) and Issue #42 seems deprecated, I guess it's fine to replace the "old" example project with the refactored version and we should do that together with the release of the next LEMMA version. I'll leave this issue open as a reminder.

To fix your issue with building the project locally even with the missing Nexus repository remove the line examples/model-processing from your local lemma-build-modules.txt.

@frademacher frademacher removed the bug Something isn't working label Dec 17, 2021
@josor001
Copy link
Collaborator Author

thx for clarifying :)!

@frademacher
Copy link
Collaborator

As written above, I'd like to keep the issue open as a reminder for the eventual removal of the old model processing example with the next LEMMA release.

@frademacher frademacher reopened this Dec 20, 2021
@frademacher frademacher self-assigned this Dec 20, 2021
@frademacher
Copy link
Collaborator

As discussed above, I just removed the old model processing example with commit b9ce7cf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants