Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous posterior covariance with preconditioned CGD #5

Open
SebastianCallh opened this issue Apr 1, 2023 · 4 comments
Open

Comments

@SebastianCallh
Copy link
Owner

We expect the P-CGD strategy to converge to the same posterior as vanilla CGD, but currently the variance doesn't seem to be updated properly - the posterior variance is much too big.

@sethaxen
Copy link

I'm happy to look into this.

@sethaxen
Copy link

Seems to relate #3 (comment)

@SebastianCallh
Copy link
Owner Author

SebastianCallh commented Jun 23, 2023

Thank you, that's super appreciated!

Let me know if I can help somehow or if the current implementation needs clarifications.

@SebastianCallh
Copy link
Owner Author

I gave this some more time and reproduced the issue in a self-contained file with preconditioned conjugate gradients for regular GPs. Didn't make any more progress yet but I put the code in this gist
https://gist.github.com/SebastianCallh/738fda183bf8675697ec954e160c75ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants