-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix erroneous posterior covariance with preconditioned CGD #5
Comments
I'm happy to look into this. |
Seems to relate #3 (comment) |
Thank you, that's super appreciated! Let me know if I can help somehow or if the current implementation needs clarifications. |
I gave this some more time and reproduced the issue in a self-contained file with preconditioned conjugate gradients for regular GPs. Didn't make any more progress yet but I put the code in this gist |
We expect the P-CGD strategy to converge to the same posterior as vanilla CGD, but currently the variance doesn't seem to be updated properly - the posterior variance is much too big.
The text was updated successfully, but these errors were encountered: