From b35321bc2e984259e96e4344c30c0213a60c8e65 Mon Sep 17 00:00:00 2001 From: chyett home Date: Thu, 25 Jan 2024 06:54:04 -0500 Subject: [PATCH 1/2] test_throws -> test_broken --- test/pde_systems/MOL_1D_HigherOrder.jl | 2 +- test/pde_systems/MOL_1D_Integration.jl | 8 ++++---- test/pde_systems/MOL_1D_Linear_Convection.jl | 3 ++- test/pde_systems/MOL_Mixed_Deriv.jl | 3 ++- test/pde_systems/MOLtest2.jl | 10 +++++----- 5 files changed, 14 insertions(+), 12 deletions(-) diff --git a/test/pde_systems/MOL_1D_HigherOrder.jl b/test/pde_systems/MOL_1D_HigherOrder.jl index 984bb9957..830fc7f46 100644 --- a/test/pde_systems/MOL_1D_HigherOrder.jl +++ b/test/pde_systems/MOL_1D_HigherOrder.jl @@ -36,7 +36,7 @@ using ModelingToolkit: Differential @named pdesys = PDESystem(eq,bcs,domains,[t,x],[u(t,x)]) discretization = MOLFiniteDifference([x=>dx],t, approx_order=4) - @test_throws ArgumentError discretize(pdesys,discretization) + @test_broken discretize(pdesys,discretization) isa ODEProblem # prob = discretize(pdesys,discretization) # sol = solve(prob, FBDF()) diff --git a/test/pde_systems/MOL_1D_Integration.jl b/test/pde_systems/MOL_1D_Integration.jl index 2c5d7d0cf..ec9cc0872 100644 --- a/test/pde_systems/MOL_1D_Integration.jl +++ b/test/pde_systems/MOL_1D_Integration.jl @@ -64,8 +64,8 @@ end disc = MOLFiniteDifference([x => 120], t) - @test_throws AssertionError (prob = discretize(pde_system, disc)) - + @test_broken (discretize(pde_system, disc) isa ODEProblem) + # prob = discretize(pde_system, disc) # sol = solve(prob, Tsit5()) # xdisc = sol[x] @@ -145,8 +145,8 @@ end disc = MOLFiniteDifference([x => 120], t) - @test_throws ArgumentError (prob = discretize(pde_system, disc)) - + @test_broken (discretize(pde_system, disc) isa ODEProblem) + # prob = discretize(pde_system, disc) # sol = solve(prob, Tsit5(), saveat=0.1) # xdisc = sol[x] diff --git a/test/pde_systems/MOL_1D_Linear_Convection.jl b/test/pde_systems/MOL_1D_Linear_Convection.jl index 594ece369..bcf6e54a1 100644 --- a/test/pde_systems/MOL_1D_Linear_Convection.jl +++ b/test/pde_systems/MOL_1D_Linear_Convection.jl @@ -439,8 +439,9 @@ end discretization = MOLFiniteDifference([x => dx], t) # Convert the PDE problem into an ODE problem - @test_throws "InterfaceBoundary has no field order" (prob = discretize(pdesys, discretization)) + @test_broken (discretize(pdesys, discretization) isa ODEProblem) + # prob = discretize(pdesys, discretization) # Solve ODE problem # using OrdinaryDiffEq # sol = solve(prob, FBDF(), saveat=0.1) diff --git a/test/pde_systems/MOL_Mixed_Deriv.jl b/test/pde_systems/MOL_Mixed_Deriv.jl index b146ba3df..6b23e68b5 100644 --- a/test/pde_systems/MOL_Mixed_Deriv.jl +++ b/test/pde_systems/MOL_Mixed_Deriv.jl @@ -32,7 +32,8 @@ using ModelingToolkit: Differential dx = (xmax-xmin)/20 discretization = MOLFiniteDifference([x => dx], t, advection_scheme = WENOScheme()) - @test_throws "ExtraVariables" (prob = discretize(pdesys, discretization)) + @test_broken (discretize(pdesys, discretization) isa ODEProblem) + # prob = discretize(pdesys, discretization) # sol = solve(prob, FBDF()) # xdisc = sol[x] diff --git a/test/pde_systems/MOLtest2.jl b/test/pde_systems/MOLtest2.jl index 87423bf6c..db7465b75 100644 --- a/test/pde_systems/MOLtest2.jl +++ b/test/pde_systems/MOLtest2.jl @@ -43,7 +43,7 @@ using Test diff_eq = ∂t(c(x, t)) ~ ∂x(D * ∂x(c(x, t))) @named pdesys = PDESystem(diff_eq, bcs, domains, [x, t], [c(x, t)]) discretization = MOLFiniteDifference([x => Δx], t) - @test_throws ArgumentError (prob = discretize(pdesys, discretization)) + @test_broken (discretize(pdesys, discretization) isa ODEProblem) end @testset "Test 02: ∂t(c(x, t)) ~ ∂x(D * ∂x(c(x, t)))" begin @@ -65,7 +65,7 @@ using Test diff_eq = ∂t(c(x, t)) ~ ∂x(D₀ / (1.0 + exp(α * (c(x, t) - χ))) * ∂x(c(x, t))) @named pdesys = PDESystem(diff_eq, bcs, domains, [x, t], [c(x, t)]) discretization = MOLFiniteDifference([x => Δx], t) - @test_throws ArgumentError (prob = discretize(pdesys, discretization)) + @test_broken (discretize(pdesys, discretization) isa ODEProblem) end @testset "Test 05: ∂t(c(x, t)) ~ ∂x(1/x * ∂x(c(x, t)))" begin @@ -93,21 +93,21 @@ using Test diff_eq = ∂t(c(x, t)) ~ c(x, t) * ∂x(c(x, t) * ∂x(c(x, t))) @named pdesys = PDESystem(diff_eq, bcs, domains, [x, t], [c(x, t)]) discretization = MOLFiniteDifference([x => Δx], t) - @test_throws "ExtraVariables" (prob = discretize(pdesys, discretization)) + @test_broken (discretize(pdesys, discretization) isa ODEProblem) end @testset "Test 09: ∂t(c(x, t)) ~ c(x, t) * ∂x(c(x,t) * ∂x(c(x, t)))/(1+c(x,t))" begin diff_eq = c(x, t) * ∂x(c(x, t) * ∂x(c(x, t))) / (1 + c(x, t)) ~ 0 @named pdesys = PDESystem(diff_eq, bcs, domains, [x, t], [c(x, t)]) discretization = MOLFiniteDifference([x => Δx], t) - @test_throws "ExtraVariables" (prob = discretize(pdesys, discretization)) + @test_broken (discretize(pdesys, discretization) isa ODEProblem) end @testset "Test 10: ∂t(c(x, t)) ~ c(x, t) * ∂x(c(x,t) * ∂x(c(x, t)))/(1+c(x,t))" begin diff_eq = c(x, t) * ∂x(c(x, t)^(-1) * ∂x(c(x, t))) ~ 0 @named pdesys = PDESystem(diff_eq, bcs, domains, [x, t], [c(x, t)]) discretization = MOLFiniteDifference([x => Δx], t) - @test_throws "ExtraVariables" prob = discretize(pdesys, discretization) + @test_broken (discretize(pdesys, discretization) isa ODEProblem) end @testset "Test 11: ∂t(c(x, t)) ~ ∂x(1/(1+c(x,t)^2) ∂x(c(x, t)))" begin From 0c6b918a492a88ff4b2b3e53a32e1d284ceb8cc8 Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Thu, 25 Jan 2024 11:50:14 -0500 Subject: [PATCH 2/2] Update Project.toml --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index 4b281b4df..360d5d6a8 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "MethodOfLines" uuid = "94925ecb-adb7-4558-8ed8-f975c56a0bf4" authors = ["Alex Jones, "] -version = "0.10.5" +version = "0.10.6" [deps] Combinatorics = "861a8166-3701-5b0c-9a16-15d98fcdc6aa"