You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Sometimes when parameter estimating ODE-models, or when importing a model in the SBML format, event time-points are dependent on model parameters. As I understood PresetTimeCallback accepts a vector of event-times, so it cannot be used (without rebuilding the callback for each parameter vector) when event-times are model parameter dependent.
Describe the solution you’d like
I would like PresetTimeCallback to also accept a function like:
functionget_tstops(integrator) ...end
And that a preset callback then can be created with
PresetTimeCallback(get_tstops, user_affect!; ...)
Describe alternatives you’ve considered
Currently in PEtab.jl and SBMLImporter if we have events we provide a function for computing tstops:
Is your feature request related to a problem? Please describe.
Sometimes when parameter estimating ODE-models, or when importing a model in the SBML format, event time-points are dependent on model parameters. As I understood PresetTimeCallback accepts a vector of event-times, so it cannot be used (without rebuilding the callback for each parameter vector) when event-times are model parameter dependent.
Describe the solution you’d like
I would like PresetTimeCallback to also accept a function like:
And that a preset callback then can be created with
Describe alternatives you’ve considered
Currently in PEtab.jl and SBMLImporter if we have events we provide a function for computing tstops:
It works, but the interface would be cleaner and more easy to use if we did not have to return the
get_tstops
function.The text was updated successfully, but these errors were encountered: