Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming and returns from datasets_create and update_dataset #33

Open
toqduj opened this issue Nov 14, 2022 · 3 comments
Open

Comments

@toqduj
Copy link
Collaborator

toqduj commented Nov 14, 2022

Naming of these methods isn't consistent, the second probably should be dataset_update (and the first dataset_create). Secondly, datasets_create returns a json model, while update_dataset returns a pid.
Something to tackle for the refactor, methinks.

@dylanmcreynolds
Copy link
Collaborator

Yes, there has been a lot of talk about a refactor to make more consistent names throughout, especially as we think about adding more functionality to support proposals, samples, etc. @nitrosx and have been talking about this, but haven't had time to implement yet.

@toqduj
Copy link
Collaborator Author

toqduj commented Nov 15, 2022

I can imagine. If it would help, we could reserve a few days for a micro-code-camp early next year?

@dylanmcreynolds
Copy link
Collaborator

Yeah, that would be cool. I think so much of our momentum this year will towards getting the new backend out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants