-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upsert dataset methods and new backend #19
Comments
At the developer meeting, we discussed whether the new backend would support upsert, and the answer was no, it will not. Therefore, we decided to remove it from the pyscicat code. Some code at RFI will be have to be rewritten to accommodate this change. |
I see, thank you for the update on the developer meeting and apologies I couldn't make it. I had a quick look at the new scicat backend and it looks like it still makes use of an update dataset method. For us, an update/patch dataset method would most likely cover the use cases that upsert is used for and would hopefully be compatible with both current and next scicat backends. |
is there a convenience method perhaps to check if a dataset exists (creating a new one if not and updating if yes)? |
Right now there is no method in the server that just checks for the existence. If you know the PID of the dataset, you can use a GET on |
@abigailalexander recently added upsert functionality into pyscicat. I'm trying to add support for the new backend into pyscicat. One issue that upsert has not been implemented. I'm curious how much we should push to get it in, or if the use cases could be accomplished with a patch?
I've submitted an issue to track this in the new backend project SciCatProject/scicat-backend-next#93
The text was updated successfully, but these errors were encountered: