Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot Download Error with answer details not working #10

Open
benesche1 opened this issue May 11, 2019 · 14 comments
Open

Screenshot Download Error with answer details not working #10

benesche1 opened this issue May 11, 2019 · 14 comments
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@benesche1
Copy link

Chrome is getting a Network error when I try to download a Screenshot while the answer details are displayed. Otherwise it works fine.
What's also weird is that Chrome isn't letting me open the picture in another tap when i displayed the answer details

@Scarwolf Scarwolf added bug Something isn't working question Further information is requested labels May 11, 2019
@Scarwolf
Copy link
Owner

Thanks for reporting. Unfortunately I can not reproduce this.

Could you try opening the Dev-Console (F12) before clicking on the Download Screenshot Button and tell me what the Console says?

image

Also can you tell me what Poll you used?

@benesche1
Copy link
Author

benesche1 commented May 12, 2019

I looks like that it is only broken when you use the json of the "Das pr0 liebt Waffen" poll
https://pr0p0ll.com/?p=viewjson&id=539
With other json data the bug seems to be not reproducible.
Here is the Dev-Console you asked for:
pr0p0ll-chrome

@benesche1
Copy link
Author

I tested a little bit and found another two polls with aren't downloadable, when Answer-Details are turned on.
The first is: https://pr0p0ll.com/?p=viewresults&id=710
Dev tools:
image
And the second one is: https://pr0p0ll.com/?p=viewresults&id=714
Dev tools:
image

@Scarwolf
Copy link
Owner

Thanks for reaching back. Unfortunately I can still not manage to reproduce this.

Since the poll is very long and the endresult-picture is 11471px in height, my guess is that the image will be displayed in Base64 it is sheer to big to be shown on some computers. Might relate to your PC specs.

In the future I will try to provide the auto-download feature for the screenshots again which will hopefully work on all major browsers.

@benesche1
Copy link
Author

Ok. When you say it is spec related, do you think it is more a ram, CPU or configuration in general related problem.

@benesche1
Copy link
Author

Update: I tested the pr0p0ll-viewer today with Microsoft Edge and one poll wich Chrome does not want to download works absolutely fine on Edge.
So i wonder if you also used a different browser than chrome for your testing.

@Scarwolf
Copy link
Owner

Hey, sorry for the late answer.

Yes, the pr0p0ll viewer has been tested on multiple browsers, but I usually aim to only provider Support from Chrome & Firefox due to their high market share.

I will test various polls with various browsers over the next few weeks and try to optimize the download as far as possible.

More example to reproduce along with the browser, version and OS are appreciated! :)

@Scarwolf Scarwolf added the help wanted Extra attention is needed label May 18, 2019
@benesche1
Copy link
Author

benesche1 commented May 18, 2019

My guess with this Issue in particular is, that it is no an issue with pr0p0ll-viewer and more an issue with the browser engines handling base64 to image conversion.
I used this poll: https://pr0p0ll.com/?p=viewresults&id=507 and tested it on Chrome, Edge and Firefox
Chrome: Won't donwnload at all
Edge: cuts of the picture at the second last question
Firefox: Won't display bars where edge cut the Picture off
And i also tested another base64 to image tool with had the same issues
Edge Screenshot:
image

Firefox screenshot:
image

Tested on: Windows 10 Version 1803 with 8 GB RAM and an i5-7200U

@RundesBalli
Copy link
Contributor

Edge: cuts of the picture at the second last question

I don't know where I got that information from anymore.
According to my knowledge IE/Edge cuts images above 8xxx pixels in height.
Maybe this will help with the troubleshooting.

@Scarwolf
Copy link
Owner

image

You're right, IE cuts images which are greater than 8192px on one side. I guess this is the same for Edge until they've switched to Chromium.

I might add a warning for Edge/IE Users.

@benesche1
Copy link
Author

I looked a little bit more around find the behavior of chrome really strange. With an image of 1710x15273 pixels (combined 26.116.830‬ pixels) we are not nearly at the limit but it won't let me download it. However, as a workaround, I can copy the image an past it into MS Paint and store it though this way. So you could add this as a note in the download section.

I also wounder why you guys can't reproduce the issue. Maybe my 8 GB of RAM aren't enough for Chrome to perform the operation?
As I also found out the issue isn't limited to pr0p0ll-viewer, but more a general issue of chrome handling images with large data url sources. Again is it my limited amount of ram available or have you guys a other idea why chrome behaves like this.

@Scarwolf
Copy link
Owner

Scarwolf commented Jun 4, 2019

So you are saying you can not download it by right clicking and selecting "Save"? What happens if you do?

@benesche1
Copy link
Author

benesche1 commented Jun 4, 2019

yes i can't download the pictures.
First of all Chrome is only letting me download and copy, not open in another tab as seen here:
save
And then, after Chrome started the download, it throws a network error
download error

@Scarwolf
Copy link
Owner

Scarwolf commented Jun 6, 2019

Possible Solution: https://stackoverflow.com/questions/38781968/problems-downloading-big-filemax-15-mb-on-google-chrome

Going to try this later, and will notify you to test it out. @benesche1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants