Fixed [BUG] u256> display for non-zero u256 #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jrcarlos2000 <[email protected]> Co-authored-by: Eduardo <[email protected]> Co-authored-by: Gabriela del Pilar Rojas <[email protected]>
# Conflicts: # README.md # packages/nextjs/app/debug/_components/contract/ContractInput.tsx # packages/nextjs/app/debug/_components/contract/utilsDisplay.tsx # packages/nextjs/components/scaffold-stark/Faucet.tsx # packages/nextjs/package.json # packages/nextjs/styles/globals.css # packages/nextjs/utils/scaffold-stark/contract.ts # packages/nextjs/utils/scaffold-stark/types.ts # packages/snfoundry/contracts/Scarb.toml # packages/snfoundry/contracts/src/YourContract.cairo # yarn.lock
…3-Labs/scaffold-stark-2 into v3-bulletproof-contracts
metalboyrick
requested changes
Dec 23, 2024
| @@ -129,9 +129,9 @@ export const EtherInput = ({ | |||
|
|
|||
| return ( | |||
| <InputBase | |||
| name={name} | |||
| name={name?.replace(">", "")} | |||
There was a problem hiding this comment.
can't fix it like this because this will break happy paths
|
GM @jedstroke seems like we will not be able to finish the PR in due time. Therefore we would not be able to consider this PR as an ODHack 11 PR, but you can still work on it but the rewards will not be part of the ODHack11 reward. Really appreciate the attempt! |
|
Hello @jedstroke thank you for your contribution, this PR needs a lot of changes that explain many files uploaded that should not be, we close the issue by this ODHack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG] u256> display for non-zero u256
Fixes #344
Types of change
Comments (optional)