Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-tab]: icon is misaligned in high-contrast themes #10455

Closed
1 task done
duygu-rmdn opened this issue Jan 3, 2025 · 1 comment · Fixed by #10467
Closed
1 task done

[ui5-tab]: icon is misaligned in high-contrast themes #10455

duygu-rmdn opened this issue Jan 3, 2025 · 1 comment · Fixed by #10467
Assignees
@s-todorova
Labels
bug This issue is a bug in the code Medium Prio released TOPIC RD

Comments

@duygu-rmdn
Copy link

Bug Description

Reproducible for Horizon and Quartz high contrast themes.

Affected Component

ui5-tab

Expected Behaviour

No response

Isolated Example

https://sap.github.io/ui5-webcomponents/play/#eyJpbmRleC5odG1sIjp7Im5hbWUiOiJpbmRleC5odG1sIiwiY29udGVudCI6IjwhLS0gcGxheWdyb3VuZC1mb2xkIC0tPlxuPCFET0NUWVBFIGh0bWw-XG48aHRtbCBsYW5nPVwiZW5cIj5cblxuXG48aGVhZD5cbiAgICBcbiAgICA8c3R5bGU-XG4gICAgICAqOm5vdCg6ZGVmaW5lZCkge1xuICAgICAgICBkaXNwbGF5OiBub25lO1xuICAgICAgfVxuXG4gICAgaHRtbCB7XG4gICAgICBmb3JjZWQtY29sb3ItYWRqdXN0OiBub25lO1xuICAgIH1cbiAgICA8L3N0eWxlPlxuXG4gICAgXG4gICAgPHN0eWxlPlxuICAgICAgKjpub3QoOmRlZmluZWQpIHtcbiAgICAgICAgZGlzcGxheTogbm9uZTtcbiAgICAgIH1cblxuICAgIGh0bWwge1xuICAgICAgZm9yY2VkLWNvbG9yLWFkanVzdDogbm9uZTtcbiAgICB9XG4gICAgPC9zdHlsZT5cblxuICAgIDxtZXRhIGNoYXJzZXQ9XCJVVEYtOFwiPlxuICAgIDxtZXRhIG5hbWU9XCJ2aWV3cG9ydFwiIGNvbnRlbnQ9XCJ3aWR0aD1kZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9MS4wXCI-XG4gICAgPHRpdGxlPlNhbXBsZTwvdGl0bGU-XG48L2hlYWQ-XG48Ym9keSBzdHlsZT1cImJhY2tncm91bmQtY29sb3I6IHZhcigtLXNhcEJhY2tncm91bmRDb2xvcik7XCI-XG48IS0tIHBsYXlncm91bmQtZm9sZC1lbmQgLS0-XG5cbjx1aTUtdGFiY29udGFpbmVyIGlkPVwidGFiQ29udGFpbmVyMVwiIGNvbGxhcHNlZD5cbiAgICA8dWk1LXRhYiBzdGFibGUtZG9tLXJlZj1cInByb2R1Y3RzLXJlZlwiIHRleHQ9XCJQcm9kdWN0c1wiIGFkZGl0aW9uYWwtdGV4dD1cIjEyNVwiPjwvdWk1LXRhYj5cbiAgICA8dWk1LXRhYi1zZXBhcmF0b3I-PC91aTUtdGFiLXNlcGFyYXRvcj5cbiAgICA8dWk1LXRhYiBpY29uPVwic2FwLWljb246Ly9tZW51MlwiIHRleHQ9XCJMYXB0b3BzXCIgZGVzaWduPVwiUG9zaXRpdmVcIiBhZGRpdGlvbmFsLXRleHQ9XCIyNVwiPjwvdWk1LXRhYj5cbiAgICA8dWk1LXRhYiBpY29uPVwic2FwLWljb246Ly9tZW51XCIgdGV4dD1cIk1vbml0b3JzXCIgc2VsZWN0ZWQgZGVzaWduPVwiQ3JpdGljYWxcIj48L3VpNS10YWI-XG4gICAgPHVpNS10YWIgaWNvbj1cInNhcC1pY29uOi8vbWVudTJcIiB0ZXh0PVwiS2V5Ym9hcmRzXCIgZGVzaWduPVwiTmVnYXRpdmVcIiBhZGRpdGlvbmFsLXRleHQ9XCIxNVwiPjwvdWk1LXRhYj5cbiAgICA8dWk1LXRhYiBpY29uPVwic2FwLWljb246Ly9tZW51MlwiIGRpc2FibGVkIHRleHQ9XCJEaXNhYmxlZFwiIGRlc2lnbj1cIk5lZ2F0aXZlXCIgYWRkaXRpb25hbC10ZXh0PVwiNDBcIj48L3VpNS10YWI-XG4gICAgPHVpNS10YWIgaWNvbj1cInNhcC1pY29uOi8vbWVudTJcIiB0ZXh0PVwiTmV1dHJhbFwiIGRlc2lnbj1cIk5ldXRyYWxcIiBhZGRpdGlvbmFsLXRleHQ9XCI0MFwiPjwvdWk1LXRhYj5cbiAgICA8dWk1LXRhYiBpY29uPVwic2FwLWljb246Ly9tZW51MlwiIHRleHQ9XCJEZWZhdWx0XCIgYWRkaXRpb25hbC10ZXh0PVwiNDBcIj48L3VpNS10YWI-XG48L3VpNS10YWJjb250YWluZXI-XG48IS0tIHBsYXlncm91bmQtZm9sZCAtLT5cbiAgICA8c2NyaXB0IHR5cGU9XCJtb2R1bGVcIiBzcmM9XCJtYWluLmpzXCI-PC9zY3JpcHQ-XG48L2JvZHk-XG48L2h0bWw-XG48IS0tIHBsYXlncm91bmQtZm9sZC1lbmQgLS0-XG5cbiJ9LCJtYWluLmpzIjp7Im5hbWUiOiJtYWluLmpzIiwiY29udGVudCI6Ii8qIHBsYXlncm91bmQtaGlkZSAqL1xuaW1wb3J0IFwiLi9wbGF5Z3JvdW5kLXN1cHBvcnQuanNcIjtcbi8qIHBsYXlncm91bmQtaGlkZS1lbmQgKi9cbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy9kaXN0L1RhYkNvbnRhaW5lci5qc1wiO1xuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzL2Rpc3QvVGFiLmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMvZGlzdC9UYWJTZXBhcmF0b3IuanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy9kaXN0L0xhYmVsLmpzXCI7XG5pbXBvcnQgXCJAdWk1L3dlYmNvbXBvbmVudHMtaWNvbnMvZGlzdC9hZGQuanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy1pY29ucy9kaXN0L2FjdGl2aXRpZXMuanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy1pY29ucy9kaXN0L2FjdGlvbi1zZXR0aW5ncy5qc1wiO1xuaW1wb3J0IFwiQHVpNS93ZWJjb21wb25lbnRzLWljb25zL2Rpc3QvY2FsZW5kYXIuanNcIjtcbmltcG9ydCBcIkB1aTUvd2ViY29tcG9uZW50cy1pY29ucy9kaXN0L21lbnUuanNcIjsifX0

Steps to Reproduce

...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

2.5.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@duygu-rmdn duygu-rmdn added the bug This issue is a bug in the code label Jan 3, 2025
@s-todorova s-todorova self-assigned this Jan 3, 2025
s-todorova added a commit that referenced this issue Jan 6, 2025
@s-todorova
fix(ui5-tab): semantic icon is properly aligned in high contrast themes
c352dd4 
fixes: #10455
@s-todorova s-todorova mentioned this issue Jan 6, 2025
Merged
@github-project-automation github-project-automation bot moved this from New Issues to Completed in Maintenance - Topic RD Jan 17, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.7.0-rc.1 🎉

The release is available on v2.7.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s-todorova s-todorova

Labels
bug This issue is a bug in the code Medium Prio released TOPIC RD
Projects
Maintenance - Topic RD
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-tab): semantic icon is properly aligned in high contrast themes SAP/ui5-webcomponents
3 participants
@duygu-rmdn @s-todorova @ui5-webcomponents-bot