Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-daterange-picker test failure #10451

Closed
1 task done
vladitasev opened this issue Jan 2, 2025 · 0 comments · Fixed by #10532
Closed
1 task done

ui5-daterange-picker test failure #10451

vladitasev opened this issue Jan 2, 2025 · 0 comments · Fixed by #10532
Assignees
@didip1000
Labels
bug This issue is a bug in the code TOPIC B

Comments

@vladitasev
Copy link
Contributor

vladitasev commented Jan 2, 2025 •
edited
Loading

Bug Description

A test passes only if the current year is 2024.

See my quick fix: #10450

Please re-write this test in such a way that it always works.

Affected Component

No response

Expected Behaviour

The test passes even if the current year is not 2024

Isolated Example

No response

Steps to Reproduce

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@vladitasev vladitasev added bug This issue is a bug in the code TOPIC B labels Jan 2, 2025
@didip1000 didip1000 self-assigned this Jan 8, 2025
@didip1000 didip1000 moved this from New Issues to In Progress in Maintenance - Topic B Jan 8, 2025
@didip1000 didip1000 mentioned this issue Jan 13, 2025
Merged
didip1000 added a commit that referenced this issue Jan 16, 2025
@didip1000
chore: stabilize test (#10532)
ef037bd 
The test would fail because the years in `ui5-year-picker` shift depending on the current year. This fix updates the test to use the first year in the picker, which is always at the first index.

Fixes: #10451
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Maintenance - Topic B Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@didip1000 didip1000

Labels
bug This issue is a bug in the code TOPIC B
Projects
Maintenance - Topic B
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: stabilize test SAP/ui5-webcomponents
2 participants
@vladitasev @didip1000