Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SF][DynamicPage]: header content has too much padding #10413

Open
1 task done
summer2200 opened this issue Dec 18, 2024 · 2 comments · May be fixed by #10448
Open
1 task done

[SF][DynamicPage]: header content has too much padding #10413

summer2200 opened this issue Dec 18, 2024 · 2 comments · May be fixed by #10448
Assignees
@NakataCode
Labels
bug This issue is a bug in the code SAP SF TOPIC P

Comments

@summer2200
Copy link

Describe the bug

UX has reported there're too much spacing between page title and page content. Regarding design guideline, the padding-top and padding-bottom of div.ui5-dynamic-page-header-root seems unnecessary
https://sap.github.io/ui5-webcomponents-react/v2/?path=/docs/layouts-floorplans-dynamicpage--docs#example
Image

Isolated Example

No response

Reproduction steps

...

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

v2.5.0

UI5 Web Components Version

v2.5.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output



Organization


No response


Declaration


    

  •  I’m not disclosing any internal or sensitive information.
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @Lukas742





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

  





      


        


  
    

      
          
Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @Lukas742
Lukas742




        transferred this issue from SAP/ui5-webcomponents-react


      Dec 18, 2024

    

  



    


    







      

  
      



  

  @Valkanister





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

      

      
            Valkanister
  

      

      

      commented


        Dec 18, 2024


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

      
    
  



    


  





      


        


  
    

      
          
"Hello @SAP/ui5-webcomponents-topic-p , take a look of this bug in the Dynamic Page"

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            


    

    

      
    

    


      

          @ilhan007
ilhan007




          added
  the 

  bug

  This issue is a bug in the code
 label


      Dec 18, 2024

    

  



    

    

      
    

    


      

          @NakataCode
NakataCode




              self-assigned this


      Dec 18, 2024

    

  



    


    

    

      
    

    


      

          @NakataCode
NakataCode




              self-assigned this


      Dec 19, 2024

    

  



    

    

      
    

    


      

          @NakataCode
NakataCode




          moved this from Issues
  to In Progress
  in Maintenance - Topic P


      Dec 20, 2024

    

  



  

  

    
  


  

      

    @NakataCode
NakataCode



    linked a pull request
    
      Jan 2, 2025
    

    that will
    close
    this issue





  


  

      
   Open

  







  




    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @NakataCode
  
    NakataCode
    

      








      


  


  

    Labels
  



    

      

    bug

  This issue is a bug in the code
  

    SAP SF

  

    TOPIC P









      

  

    

        

    Projects
  


        




        
  

    

      
          
        Maintenance - Topic P
    

    

      

            
    Status: In Progress


      

    

    

  



        
  

    

      
          
        ui5-webcomponents-react Roadmap
        
    

    

      

            
    Status: 🆕 New

              
      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      fix(ui5-dynamic-page): remove redundant padding

    
      SAP/ui5-webcomponents
    





    
  




      

    

  
      

  

    

      6 participants
    

    

        
          @petyabegovska 
        
          @Lukas742 
        
          @ilhan007 
        
          @summer2200 
        
          @NakataCode 
        
          @Valkanister