Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-card-header]: The focusable DIV lacks a role attribute. #10367

Closed
1 task done
shakogele01 opened this issue Dec 12, 2024 · 1 comment · Fixed by #10437
Closed
1 task done

[ui5-card-header]: The focusable DIV lacks a role attribute. #10367

shakogele01 opened this issue Dec 12, 2024 · 1 comment · Fixed by #10437
Assignees
Labels

Comments

@shakogele01
Copy link

shakogele01 commented Dec 12, 2024

Bug Description

Access Assistant reports following - This DIV is focusable but lacks a role attribute. (Please see the attached pictures).

If we follow the Accessibility Best Practice - adding a role helps provide context, making it clear to users relying on screen readers what kind of interactive element they are encountering. However it is not possible to assign role attribute to the focusable div. If we pass down interactive prop to the CardHeader, this will assign the role="Button" to the focusable DIV, which makes the header clickable, and also changes the way the header looks and behaves on hover.

Screenshot 2024-12-12 at 10 29 41

Affected Component

ui5-card-header

Expected Behaviour

We should be able to assign the role=<anyRole> attribute to the focusable div element.

Isolated Example

https://js-xw5smpxh.stackblitz.io/

Steps to Reproduce

  1. open the stackblitz isolated example
  2. install the Access Assistant extention
  3. scan the isolated example
  4. check the report on focusable div

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

2.5.0

Browser

Chrome, Safari

Operating System

MacOS

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@shakogele01 shakogele01 added the bug This issue is a bug in the code label Dec 12, 2024
@shakogele01 shakogele01 changed the title [CardHeader]: The focusable DIV lacks a role attribute. [ui5-card-header]: The focusable DIV lacks a role attribute. Dec 12, 2024
@GerganaKremenska GerganaKremenska self-assigned this Dec 23, 2024
@github-project-automation github-project-automation bot moved this from New Issues to Completed in Maintenance - Topic RD Jan 22, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.7.0-rc.1 🎉

The release is available on v2.7.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants