From c6a822c73a4b851e6b2ea84be40d41748b679efb Mon Sep 17 00:00:00 2001 From: "mikerodonnell89@gmail.com" Date: Mon, 6 Jan 2025 13:35:50 -0500 Subject: [PATCH 1/2] fix(core): make popover body have dialog role by default --- libs/core/src/lib/popover/base/base-popover.class.ts | 2 +- .../core/src/lib/popover/popover-body/popover-body.component.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/core/src/lib/popover/base/base-popover.class.ts b/libs/core/src/lib/popover/base/base-popover.class.ts index e4c546d884e..3516aeb2627 100644 --- a/libs/core/src/lib/popover/base/base-popover.class.ts +++ b/libs/core/src/lib/popover/base/base-popover.class.ts @@ -160,7 +160,7 @@ export class BasePopoverClass { isOpenChange: EventEmitter = new EventEmitter(); /** @hidden Aria role for the popover body. */ - _bodyRole: string | null = null; + _bodyRole: string | null = 'dialog'; /** @hidden ID for the popover body. */ _bodyId: string | null = null; diff --git a/libs/core/src/lib/popover/popover-body/popover-body.component.ts b/libs/core/src/lib/popover/popover-body/popover-body.component.ts index dabfcb42159..3cf6f6993ce 100644 --- a/libs/core/src/lib/popover/popover-body/popover-body.component.ts +++ b/libs/core/src/lib/popover/popover-body/popover-body.component.ts @@ -84,7 +84,7 @@ export class PopoverBodyComponent implements AfterViewInit { _closeOnEscapeKey = false; /** @hidden Aria role for the popover body */ - _bodyRole: Nullable = null; + _bodyRole: Nullable = 'dialog'; /** @hidden Aria role for the popover body */ _bodyId: Nullable = null; From 85b89007c7bb066eb01c624773c8cb9417a1c4bd Mon Sep 17 00:00:00 2001 From: "mikerodonnell89@gmail.com" Date: Thu, 9 Jan 2025 11:20:24 -0500 Subject: [PATCH 2/2] fix(platform): multicombobox e2e test --- libs/docs/platform/multi-combobox/e2e/multi-combobox.po.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/docs/platform/multi-combobox/e2e/multi-combobox.po.ts b/libs/docs/platform/multi-combobox/e2e/multi-combobox.po.ts index 58bf50a43ad..7e00f6f0f44 100644 --- a/libs/docs/platform/multi-combobox/e2e/multi-combobox.po.ts +++ b/libs/docs/platform/multi-combobox/e2e/multi-combobox.po.ts @@ -16,7 +16,7 @@ export class MultiComboboxPo extends PlatformBaseComponentPo { listItem = this.list + ' li.fd-list__item[role="option"]'; selectedListItem = this.list + ' .fd-list__item.is-selected .fd-list__title'; - dialog = '[role="dialog"]'; + dialog = '.fd-dialog'; dialogButton = this.dialog + ' .fd-button'; dialogListItem = this.dialog + ' .fd-list__item[role="option"]'; selectedDialogItem = this.dialog + ' .fd-list__item.is-selected .fd-list__title';