Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2][Sourcing] checkbox should not be toggled when selecting entire row in p13 dialog #12672

Closed
CSEHoangV opened this issue Oct 30, 2024 · 0 comments · Fixed by #12878
Closed
Assignees
Labels
ng15 Angular 15 support

Comments

@CSEHoangV
Copy link
Contributor

CSEHoangV commented Oct 30, 2024

Is this a bug, enhancement, or feature request?

bug

Describe your proposal.

Currently, in p13 dialog, when we select row using mouseclick, checkbox is unchecked/checked.

2024-10-30_01-02-28.mp4

This may causes user experience issue especially when they want to reorder columns but when clicking entire row, column is unchecked which makes it non-visible and the reorder will not work after save. So, to workaround this, we have to make sure to select all after the action which causes extra click.

In UI5, mouseclick on entire rows does not toggle the checked state.

2024-10-30_01-06-41.mp4

I think it should be similar when we use keyboard.

Can you handle that on the application side

No, p13 cannot be controlled by us.

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

Angular 15 or main branch
latest

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Refer to the record.

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

https://ng-15-downport--fundamental-ngx.netlify.app/#/platform/table/p13-dialog-table

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Did you check the documentation and the API?

Did you search for similar issues?

Is there anything else we should know?

IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.

@CSEHoangV CSEHoangV changed the title [P2][Sourcing] checkbox should not be toggled when mouse-clicking entire row [P2][Sourcing] checkbox should not be toggled when selecting entire row Oct 30, 2024
@CSEHoangV CSEHoangV changed the title [P2][Sourcing] checkbox should not be toggled when selecting entire row [P2][Sourcing] checkbox should not be toggled when selecting entire row in p13 dialog Oct 30, 2024
@droshev droshev added the ng15 Angular 15 support label Nov 15, 2024
@droshev droshev added this to the Sprint 140 - November 2024 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ng15 Angular 15 support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants