Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrypt: use salsa20 crate? #29

Closed
tarcieri opened this issue Jun 6, 2020 · 0 comments · Fixed by #60
Closed

scrypt: use salsa20 crate? #29

tarcieri opened this issue Jun 6, 2020 · 0 comments · Fixed by #60

Comments

@tarcieri
Copy link
Member

tarcieri commented Jun 6, 2020 •
edited
Loading

The salsa20 v0.5.0 crate now contains an implementation of Salsa20/8:

https://docs.rs/salsa20/latest/salsa20/type.Salsa8.html

Screen Shot 2020-06-06 at 10 36 10 AM

I noticed the scrypt crate presently vendors its own. I'm not sure the APIs in the salsa20 crate are sufficient to implement scrypt with it yet (it appears to require direct access to the Salsa core function?) but I think it might be interesting to try migrating it, especially if we were ever to add SIMD optimizations to the salsa20 crate (see RustCrypto/stream-ciphers#50).

We could potentially add a salsa-core cargo feature to the salsa20 crate to expose the core function.
@tarcieri tarcieri mentioned this issue Jun 10, 2020
Closed
tarcieri added a commit that referenced this issue Oct 18, 2020
@tarcieri
scrypt: use salsa20 crate to implement Salsa20/8
afd5b25 
Closes #29.

Using the `salsa20` crate allows us to focus on a single place for
things like SIMD optimizations (#16).
@tarcieri tarcieri mentioned this issue Oct 18, 2020
Merged
tarcieri added a commit that referenced this issue Oct 18, 2020
@tarcieri
scrypt: use salsa20 crate to implement Salsa20/8
b907997 
Closes #29.

Using the `salsa20` crate allows us to focus on a single place for
things like SIMD optimizations (#16).
tarcieri added a commit that referenced this issue Oct 18, 2020
@tarcieri
scrypt: use salsa20 crate to implement Salsa20/8
3502a9d 
Closes #29.

Using the `salsa20` crate allows us to focus on a single place for
things like SIMD optimizations (#16).
tarcieri added a commit that referenced this issue Oct 18, 2020
@tarcieri
scrypt: use salsa20 crate to implement Salsa20/8 (#60)
721242f 
Closes #29.

Using the `salsa20` crate allows us to focus on a single place for
things like SIMD optimizations (#16).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scrypt: use salsa20 crate to implement Salsa20/8 RustCrypto/password-hashes
1 participant
@tarcieri