Asymmetry in default features: only p384 has ecdh by default
#1047
Comments
|
Yes, it is a bit weird it's inconsistent. Alternatively we could add |
|
I'm afraid I have no useful opinion on which way to resolve this, I just stumbled over the difference 🤷 Personally, I'm happy either way. |
tarcieri
added a commit
that referenced
this issue
Jan 22, 2025
This default feature is inconsistent with all of the other curve implementations in this repo, which don't enable the `ecdh` feature by default. We could go either way, enabling it in all the other curves, or just disabling it here. This PR opts to do the latter, as it's simpler. Closes #1047
tarcieri
added a commit
that referenced
this issue
Jan 22, 2025
This default feature is inconsistent with all of the other curve implementations in this repo, which don't enable the `ecdh` feature by default. We could go either way, enabling it in all the other curves, or just disabling it here. This PR opts to do the latter, as it's simpler. Closes #1047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
p384crate differs from the other curves in that it enables theecdhfeature by default inCargo.toml.This is obviously not a huge deal, but I wonder if it would be good to remove it from the default features, for symmetry?
The text was updated successfully, but these errors were encountered: