Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEED HELP] help to list all new shiny images #218

Open
Rplus opened this issue Jul 20, 2023 · 25 comments
Open

[NEED HELP] help to list all new shiny images #218

Rplus opened this issue Jul 20, 2023 · 25 comments
Labels
help wanted Extra attention is needed

Comments

@Rplus
Copy link
Owner

Rplus commented Jul 20, 2023

I have a plan to re-make this tool.

But I am tired to match all old images and new images
So, I need someone to help to list all "new" image source path of shiny Pokemon in the list.

You could find new image path in pokeminers.
e.g. https://pokeminers.com/gmexplore/#Pikachu_Copy_2019

ps: I did not play Pokemon GO for one year.

@Rplus Rplus added the help wanted Extra attention is needed label Jul 20, 2023
@Rplus Rplus changed the title [NEED HELP] [NEED HELP] help to list all new shiny images Jul 20, 2023
@BartmanEH
Copy link
Contributor

BartmanEH commented Jul 20, 2023

this needs WAY more explanation. I have been diligently finding the image paths from this base URL:
https://github.com/PokeMiners/pogo_assets/find/master/Images/Pokemon%20-%20256x256/Addressable%20Assets/pm
and then using the pokedex number to filter down to the shiny image.

  1. Are you saying you want to change this and no longer use pokeminer github DB but instead use pokeminer website DB?

  2. How does this help with refactoring your tool? The website database doesn't seem to be any more up to date than the github one, e.g. Snorlax w Nightcap is missing in both.

  3. How do I go about making this new list. Do you just want a text list of URLs in any order without any other reference like this?
    https://pokeminers.com/gmexplore/#Pikachu_Jeju
    https://pokeminers.com/gmexplore/#Aerodactyl_Summer_2023
    ...

  4. This would end up being an unordered list since the pokeminer website URLs are not ordered by pm pokedex prefix--how will they get sorted into a logical order for new refactored list tool?

  5. Is there a current list of URLs I can work with to keep track of which ones I've converted?

@Rplus
Copy link
Owner Author

Rplus commented Jul 21, 2023

First, this checklist use two PokeMiners/pogo_assets image folder now.
I holp we could change to use newer folder for all.
For some special case (e.g. Snorlax w Nightcap), we could use custom image path temporarily.

The deeper folder (/Addressable Assets/) is PokeMiners newer system.

image
PokeMiners/pogo_assets/Images/Pokemon - 256x256/pokemon_icon_025_00_shiny.png


PokeMiners/pogo_assets/Images/Pokemon - 256x256/Addressable Assets/pm25.s.icon.png

I think it is okay to list the new shiny image name by order of current checklist.
It will use image name as id, so the order is not very important.
It will be good to collect them in Google spreadsheet at first,
and I think Google spreadsheet will be a good method for maintain with people.

I open a spreadsheet for it, people who want to help could edit directly now.
https://docs.google.com/spreadsheets/d/13UreWc5Nq4yiLYvDRt2RyPWXsDx9y4pMWhSD0JsnHCw/edit?usp=sharing

spreadsheet columns:

  • *pokemon name
  • *image name (in newer fodler)
  • family / group name (this might change after)
  • released date (nice to have)
  • custom image path

current shiny data:
(but I think it might be difficult to read by human)
https://github.com/Rplus/Pokemon-shiny/blob/master/assets/pms.json

That is all, thanks for asking~

@Rplus
Copy link
Owner Author

Rplus commented Jul 21, 2023

@BartmanEH
Copy link
Contributor

What about using a tool like https://conversiontools.io/convert/json-to-excel to convert the pms json file to a spreadsheet to start with?

@BartmanEH
Copy link
Contributor

You could find new image path in pokeminers.

e.g. https://pokeminers.com/gmexplore/#Pikachu_Copy_2019

Ok to be sure I understand what's needed--in the example URL you provide above, you don't want THAT URL, you want the URL of the image used in that URL which is the same base URL I have been using for a few months now comprising Addressable%20Assets etc BUT all the old original images are not using this new URL, they're using the older pokeminer URLs? In this case, if we can convert pms.json to Excel (Google Sheets can import excel) I think we would have a better starting point.

@BartmanEH
Copy link
Contributor

I converted the pms.json to Sheets:

https://docs.google.com/spreadsheets/d/1773q6HdntMNuqEEWBhuNWT0m_zxBTm7nzJUDKJrdReY/edit

It looks like any entry with "aa_fn" has the new URL data and any entry missing this (but is released) needs a new "aa_fn" entry using the new URL from [...]Addressable%20Assets[...], correct?

@Rplus
Copy link
Owner Author

Rplus commented Jul 22, 2023

Yes, that is it!
We need to update those three columns (fn, isotope, type) into new name system~
image

@Rplus
Copy link
Owner Author

Rplus commented Jul 22, 2023

Okay~
That is a good idea to get data from old pms.json~

I made a tool to check newer image name
https://svelte.dev/repl/d7b22c8ede244924bc886de2671deab0?version=4.1.1
Hope that could be helpful~

Now, we just need to focus on yellow grids!

  1. Check & test the name of yellow items in the tool
    you could find image name on pokeminers site quickly~
    image

  2. Enter the name into yellow grid of the sheet!
    image

https://docs.google.com/spreadsheets/d/13UreWc5Nq4yiLYvDRt2RyPWXsDx9y4pMWhSD0JsnHCw/edit#gid=0

@BartmanEH
Copy link
Contributor

BartmanEH commented Jul 22, 2023

Ok I'm going to start working on this in my spare time.

The svelte tool you made is useful to confirm exactly which type matches which URL etc. I added a button to copy the data from the text edit field to the clipboard but I couldn’t figure out how to import copy-to-clipboard components etc—I don’t know the first thing about Svelte :-( It seems the browser Svelte playground can’t access files so no import capability.

I would like to thank you for your efforts continuing to support us. We know you don't play Pokémon GO anymore so you have no need for this tool but for the rest of us, it is a convenient way to track our shinies! Thank you for applying your skilled knowledge as a developer to help us.

@BartmanEH
Copy link
Contributor

BartmanEH commented Jul 22, 2023

OK, done. Phew. MANY hours of work! The hardest one was Pikachu with no logical naming convention for the myriad variations.

The spreadsheet has been filled in except for release dates—just too much to look up. Also there’s one extra row still for UNOWN 201.

@Evillunte
Copy link

I would love to help... But im afraid to fuck it up .. have all the time in the world to do list.

But English is not my language, So not sure i understand 100% all that you write

@Rplus
Copy link
Owner Author

Rplus commented Jul 28, 2023

@Evillunte
Hi~
The image name transforming is almost okay now.
I think we just need to update the released date next.

You could update the release date with webpages in #218 (comment)
Just transform TRUE to the normal date format. :P

image

@Evillunte
Copy link

Evillunte commented Jul 28, 2023

Im on the case👍
Already update a few. I keep on going....

@Evillunte
Copy link

Is. This on the list of new upcoming pokemon. I cant see it under aerodactyl in the sheet

Screenshot_2023-07-28-10-22-09-217_com android chrome

@Evillunte
Copy link

Evillunte commented Jul 28, 2023

Another question...
Here is the date different(togekiss,magmarton) in the sheet to the link ??

IMG_20230728_105103

Screenshot_2023-07-28-10-49-55-682_com android chrome

@Rplus
Copy link
Owner Author

Rplus commented Jul 28, 2023

Hi~ @Evillunte
I think we should not discuss which pokemon is shiny or not in this issue.
Welcome to discuss "workflow" in this issue.

If you are confused about "data", just use "comment" on google spreadsheet directly.
image

@BartmanEH
Copy link
Contributor

BartmanEH commented Jul 28, 2023

Is. This on the list of new upcoming pokemon. I cant see it under aerodactyl in the sheet

That was missing, indeed. I added a row for it but @Rplus needs to check the data for it in row 291—I don’t know old_id.

@Rplus
Copy link
Owner Author

Rplus commented Jul 28, 2023

Please don't add new row for now.
This issue is just for transforminng old data to new.

If there are new shiny pokemon,
just create a new issue to add into the check list that doesn't use this spreadsheet now.

@BartmanEH
Copy link
Contributor

OK, I see you already deleted the row I added. It looks like that Aerodactyl was missed in #213

@Evillunte
Copy link

Release date on alot of pokemon is finish

only miss the event/costume pokemon like Pikachu and family, i think i can find the release date on most of them, but unsure to put the date in the sheet,the name in the sheet is not the same as there actually name.

Can i write a list somewhere with the real name and release ?

@BartmanEH
Copy link
Contributor

only miss the event/costume pokemon like Pikachu and family, i think i can find the release date on most of them, but unsure to put the date in the sheet,the name in the sheet is not the same as there actually name.

I hope this doesn’t mess up RPlus’ spreadsheet like adding rows does BUT I added a column at the extreme right with a link to the image of the pokemon

@Evillunte
Copy link

Evillunte commented Jul 28, 2023

Thx for the link to picture.👍

All release dates is finish... (All dates was taking from pokemon.fandom.)

@Rplus
Copy link
Owner Author

Rplus commented Jul 29, 2023

Thanks ALL!!! <3

@lmartins06
Copy link

Is this replacing the shiny checklist?

@BartmanEH
Copy link
Contributor

Is this replacing the shiny checklist?

It’s not ‘replacing’ it. The author of this shiny checklist tool is re-working the back end to make the tool easier to maintain going forward, however, the future of this tool is called into question by the announcement by pokeminers of their soft shutdown :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants