Internal server error on AdminProcessManagment in new session.

[svenoe]

Please try to reproduce on OTOBO 11.0 but see, whether older versions are affected:

1. Log into OTOBO, go to AdminProcessManagement and open a process.
2. In another tab remove your session in the session management and login again (to start a new session).
3. In the first tab directly clock on "new activity"

To my understanding from looking at the code this leads to an undefined ScreensPath:

otobo/Kernel/Modules/AdminProcessManagementActivity.pm

Lines 54 to 56 in 52c1cbc

	$Self->{ScreensPath} = $Kernel::OM->Get('Kernel::System::JSON')->Decode(
	Data => $SessionData{ProcessManagementScreensPath}
	);

And a following

Modification of non-creatable array value attempted, subscript -1 at /opt/otobo/bin/psgi-bin/../../Kernel/Modules/AdminProcessManagementActivity.pm line 672.

in:

otobo/Kernel/Modules/AdminProcessManagementActivity.pm

Line 672 in 52c1cbc

if ( $Self->{ScreensPath}->[-1]->{Action} eq 'AdminProcessManagement' ) {

[MichaelThumes]

replicated on ov276 for rel-11_0

Modification of non-creatable array value attempted, subscript -1 at /home/VirtualOTOBO/ov276/bin/psgi-bin/../../Kernel/Modules/AdminProcessManagementActivity.pm line 672

[bschmalhofer]

perldoc perldiag says:

    Modification of non-creatable array value attempted, %s
        (F) You tried to make an array value spring into existence, and the
        subscript was probably negative, even counting from end of the array
        backwards.

So $Self->{ScreensPath} is either not a reference to an array or a reference to an empty array.

[MichaelThumes]

replicated on 10_0 - Internal Server Error (looks different, probably custom error page instead of default, but nonetheless same Internal Server Error):

Modification of non-creatable array value attempted, subscript -1 at /opt/otobo/bin/psgi-bin/../../Kernel/Modules/AdminProcessManagementActivity.pm line 673.

[MichaelThumes]

https://github.com/RotherOSS/otobo/blob/rel-10_0/Kernel/Modules/AdminProcessManagementActivity.pm#L49

    my %SessionData = $Kernel::OM->Get('Kernel::System::AuthSession')->GetSessionIDData(
        SessionID => $Self->{SessionID},
    );

    # convert JSON string to array
    $Self->{ScreensPath} = $Kernel::OM->Get('Kernel::System::JSON')->Decode(
        Data => $SessionData{ProcessManagementScreensPath}
    );

At this point - if Session got killed/renewed in between - %SessionData will simply NOT hold a ProcessManagementScreensPath Hash key, causing the attempt to JSON decode to fail, resulting in $Self->{ScreensPath} being set to undefined. Treating it as an Array-Reference later on leads to the error msg reported.

Strategies:

• either display proper error message or
• reload parent frame and close popup

[stefanhaerter]

The bug described in #4100 actually relates to the changes made for this issue in #4026. Initially, the EntityID is an empty string for newly created activities, therefor the _GetActivityConfig() 'fails'. The new EntityID is only created afterwards, implying the necessity to fetch the activity config again.

[stefanhaerter]

closing the issue with merged #4101