Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for item pickup to be disabled in vanish instead of forced #130

Open
FigT opened this issue Nov 15, 2024 · 0 comments
Open

Option for item pickup to be disabled in vanish instead of forced #130

FigT opened this issue Nov 15, 2024 · 0 comments

Comments

@FigT
Copy link

FigT commented Nov 15, 2024

Hi there, so whilst I was trying out RoseStacker I noticed that it disables picking up items in vanish, which is fine for most people, but for vanish plugins that offer features to toggle pickup items via a command, etc - well RoseStacker overrides this.

I think it would be beneficial and easy to add a config option to toggle this functionality or not.

It would be the ItemListener and SettingKey class that needs to be modified.


I'd be fine to make a PR for this (although seems like some dependencies are missing so I can't compile it?)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant