Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate 4-5x oversampled PSFs #30

Open
laldoroty opened this issue Oct 4, 2024 · 5 comments
Open

Generate 4-5x oversampled PSFs #30

laldoroty opened this issue Oct 4, 2024 · 5 comments
Assignees

Comments

@laldoroty
Copy link
Collaborator

image

Left is original PSF, right is PSF after decorrelation.
Mapping is log scale, so it looks worse than it is.

(original notes from @rknop)

@laldoroty
Copy link
Collaborator Author

This can be done in galsim easily--https://github.com/matroxel/roman_imsim/blob/v2.0/roman_imsim/utils.py#L88

it's just a kwarg in the function we use.

@wmwv
Copy link
Collaborator

wmwv commented Oct 4, 2024

When you say "it looks worse", what's the quantitative thing you're trying to minimize?

I think it's unlikely we will actually know the PSF that much better than a few times smaller than a pixel. You shouldn't expect that a decorrelated image will look like an image. When you're operating near the sampling limit, there's just stuff you can't recover.

@laldoroty
Copy link
Collaborator Author

laldoroty commented Oct 4, 2024

@thomasvrussell @rknop

Even 2x would help, we think!

@wmwv
Copy link
Collaborator

wmwv commented Oct 7, 2024

What's the metric for improvement or success?

@wmwv
Copy link
Collaborator

wmwv commented Oct 7, 2024

On the phrosty side, the following branch now accepts additional kwargs for get_imsim_psf that will be passed on to roman_imsim getPSF_Image, which then passes that on to drawImage.

Next is to
[ ] 1. Add a test to verify this behavior
[ ] 2. Add change, configuration to diff-img preprocess.py to pass something like oversampling_factor=4 to get_imsim_psf.

Do we always want it to be something constant? Should it be a default in diff-img to be 4, should it be specified on the command line? Do we want different oversamplings for different purposes within diff-img?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants