Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Entity culling does not respect block entities on Valkyrien Skies ships. #2

Open
pikasalt opened this issue Apr 12, 2024 · 2 comments

Comments

@pikasalt
Copy link

Disabling entity culling makes rendering appear normal again. Not sure if the block entities need to be whitelisted or not.

@RogoShum
Copy link
Owner

This may have something to do with the implementation mechanics of the Valkyrie Skies ships, where the blocks are supposed to be in a coordinate that is out of the range of the screen, thanks for your feedback, and I will continue to track and fix this.

@RogoShum
Copy link
Owner

I've added a simple compatibility fix for Valkyrien in version 0.4.7. However, block entities in the Valkyrien Skies are currently not being culled. Since Valkyrien Skies doesn't seem to have a public API, I can't obtain the correct coordinates for the block entities. I'll continue tracking this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants