Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7.1.0 Breaks RocketChat.js.SDK #34131

Closed
mathematisse opened this issue Dec 6, 2024 · 1 comment
Closed

V7.1.0 Breaks RocketChat.js.SDK #34131

mathematisse opened this issue Dec 6, 2024 · 1 comment
Labels
duplicate Closed as Duplicate

Comments

@mathematisse
Copy link

Here's the link to the issue present on the repo of the sdk : RocketChat/Rocket.Chat.js.SDK#169

That issue sums up perfectly the problem, so check it out quickly !

Looking at development activity here compared to the sdk, it might be more relevant to fix that issue here instead of there, by updating the validation method for the field "bot" in https://developer.rocket.chat/v1-api/apidocs/message to match what is done on the sdk with the integration id.

@reetp
Copy link

reetp commented Dec 6, 2024

This is effectively a duplicate of the referenced bug.

You shoudl follow up there and let the developers work out what is best.

Closing as duplicate unless they want to re-open it here.

@reetp reetp closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Closed as Duplicate
Projects
None yet
Development

No branches or pull requests

2 participants